Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 959713002: [content]: Don't use task's from_here when posting delayed EnqueueTask on Task Queue Manager. (Closed)

Created:
5 years, 10 months ago by rmcilroy
Modified:
5 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[content]: Don't use task's from_here when posting delayed EnqueueTask on Task Queue Manager. When posting a delayed task in the task queue manager we post a wrapping task which enqueues the actual task on the underlying message loop. It is confusing to have this task use the actual task's from_here since it looks like the task get's run at this point, which is not the case. Committed: https://crrev.com/2794174de0ad4ee60b0a47408ec56c3de6cb2f07 Cr-Commit-Position: refs/heads/master@{#318052}

Patch Set 1 #

Patch Set 2 : Add single thread idle task runner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/scheduler/single_thread_idle_task_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
rmcilroy
Found this while trying to verify the long idle stuff works - it's a bit ...
5 years, 10 months ago (2015-02-25 13:54:11 UTC) #2
Sami
On 2015/02/25 13:54:11, rmcilroy wrote: > Found this while trying to verify the long idle ...
5 years, 10 months ago (2015-02-25 14:08:19 UTC) #3
rmcilroy
On 2015/02/25 14:08:19, Sami wrote: > On 2015/02/25 13:54:11, rmcilroy wrote: > > Found this ...
5 years, 10 months ago (2015-02-25 14:19:09 UTC) #4
Sami
On 2015/02/25 14:19:09, rmcilroy wrote: > On 2015/02/25 14:08:19, Sami wrote: > > On 2015/02/25 ...
5 years, 10 months ago (2015-02-25 14:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959713002/20001
5 years, 10 months ago (2015-02-25 14:26:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/38260)
5 years, 10 months ago (2015-02-25 14:43:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959713002/20001
5 years, 10 months ago (2015-02-25 15:06:29 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 15:41:25 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:42:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2794174de0ad4ee60b0a47408ec56c3de6cb2f07
Cr-Commit-Position: refs/heads/master@{#318052}

Powered by Google App Engine
This is Rietveld 408576698