Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 959693002: Default-enable external startup data for Linux for stand-alone builds. (Closed)

Created:
5 years, 10 months ago by vogelheim
Modified:
5 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Default-enable external startup data for Linux for stand-alone builds. Notes: - Other platforms to follow later. - This follows Chromium practice, that mostly uses this feature these days. - The statically linked-in startup data will stay. So whoever prefers the old way just needs to set the flag differently. BUG= Committed: https://crrev.com/6d0dcaabe55ca3556bebfd771fbc7fd560fdd4e0 Cr-Commit-Position: refs/heads/master@{#26884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vogelheim
5 years, 10 months ago (2015-02-25 17:34:09 UTC) #2
Michael Achenbach
lgtm
5 years, 9 months ago (2015-02-26 14:02:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959693002/1
5 years, 9 months ago (2015-02-26 14:10:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-26 14:55:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d0dcaabe55ca3556bebfd771fbc7fd560fdd4e0 Cr-Commit-Position: refs/heads/master@{#26884}
5 years, 9 months ago (2015-02-26 14:55:33 UTC) #7
vogelheim
5 years, 9 months ago (2015-02-26 15:09:22 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/962593003/ by vogelheim@chromium.org.

The reason for reverting is: Breaks "Simple Leaks Check".

Powered by Google App Engine
This is Rietveld 408576698