Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 959643003: [Gallery] Add reload feature (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Gallery] Add reload feature This patch adds a reload feature, which is that reload the gallery with new entries when a 'onLaunched' event is fired. BUG=461218 TEST=manually tested Committed: https://crrev.com/9e0fa77f5e3fa6a08be7c5fd520defebc1b25988 Cr-Commit-Position: refs/heads/master@{#318216}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M ui/file_manager/gallery/js/background.js View 3 chunks +7 lines, -17 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 2 7 chunks +30 lines, -14 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 9 months ago (2015-02-25 15:06:41 UTC) #2
fukino
lgtm!
5 years, 9 months ago (2015-02-26 05:15:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959643003/40001
5 years, 9 months ago (2015-02-26 11:33:15 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-02-26 11:42:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 11:42:43 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e0fa77f5e3fa6a08be7c5fd520defebc1b25988
Cr-Commit-Position: refs/heads/master@{#318216}

Powered by Google App Engine
This is Rietveld 408576698