Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: extensions/browser/process_manager.cc

Issue 959513002: Refactor Extension initialization logic. Add tracing and additional histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: yoz and asvitkine comments 1 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/process_manager.cc
diff --git a/extensions/browser/process_manager.cc b/extensions/browser/process_manager.cc
index 10cce73440d463ce220ef6b7221c0f0cc9a6e143..5b0bdc4e60792a6279e6a384f1666ce2df8b9da3 100644
--- a/extensions/browser/process_manager.cc
+++ b/extensions/browser/process_manager.cc
@@ -753,14 +753,13 @@ void ProcessManager::SetEventPageSuspendingTimeForTesting(
void ProcessManager::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
+ TRACE_EVENT0("browser,startup", "ProcessManager::Observe");
switch (type) {
case extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED: {
// TODO(jamescook): Convert this to use ExtensionSystem::ready() instead
// of a notification.
- const base::TimeTicks start_time = base::TimeTicks::Now();
+ SCOPED_UMA_HISTOGRAM_TIMER("Extensions.ProcessManagerStartupHostsTime");
MaybeCreateStartupBackgroundHosts();
- UMA_HISTOGRAM_TIMES("Extensions.ProcessManagerStartupHostsTime",
- base::TimeTicks::Now() - start_time);
break;
}

Powered by Google App Engine
This is Rietveld 408576698