chrome/browser/local_discovery/privet_http_asynchronous_factory.h - Issue 959503003: Remove ServiceDiscoveryClient* from PrivetHTTPAsynchronousFactoryImpl interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/privet_http_asynchronous_factory.h

Issue 959503003: Remove ServiceDiscoveryClient* from PrivetHTTPAsynchronousFactoryImpl interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixEstablish

Patch Set: Tue Feb 24 17:30:57 PST 2015 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/local_discovery/privet_http_asynchronous_factory.h

diff --git a/chrome/browser/local_discovery/privet_http_asynchronous_factory.h b/chrome/browser/local_discovery/privet_http_asynchronous_factory.h

index 388208135d2e3555dd30aa4dfcaaf4d4c3879d7e..eb6f462fa03fdef81d851c9125828055451a2b00 100644

--- a/chrome/browser/local_discovery/privet_http_asynchronous_factory.h

+++ b/chrome/browser/local_discovery/privet_http_asynchronous_factory.h

@@ -18,7 +18,7 @@ class URLRequestContextGetter;

namespace local_discovery {

class PrivetHTTPClient;

-class ServiceDiscoveryClient;

+class ServiceDiscoverySharedClient;

Aleksey Shlyapnikov 2015/02/25 01:35:38 Why do you need this declaration in this header fi

Vitaly Buka (NO REVIEWS) 2015/02/25 01:37:09 thanks, I don't

class PrivetHTTPResolution {

public:

@@ -34,7 +34,6 @@ class PrivetHTTPAsynchronousFactory {

virtual ~PrivetHTTPAsynchronousFactory() {}

static scoped_ptr<PrivetHTTPAsynchronousFactory> CreateInstance(

- ServiceDiscoveryClient* service_discovery_client,

net::URLRequestContextGetter* request_context);

virtual scoped_ptr<PrivetHTTPResolution> CreatePrivetHTTP(

« no previous file with comments | « no previous file | chrome/browser/local_discovery/privet_http_asynchronous_factory.cc » ('j') | no next file with comments »