Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 959503003: Remove ServiceDiscoveryClient* from PrivetHTTPAsynchronousFactoryImpl interface (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fixEstablish
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ServiceDiscoveryClient* from PrivetHTTPAsynchronousFactoryImpl interface PrivetHTTPAsynchronousFactoryImpl can use ServiceDiscoverySharedClient::GetInstance. Also we don't use this for testing, so we can simplify interface. BUG=461504 Committed: https://crrev.com/e61a6220ca4341f7eafac6dc3aacaa6f80a89896 Cr-Commit-Position: refs/heads/master@{#318013}

Patch Set 1 #

Patch Set 2 : Tue Feb 24 17:28:46 PST 2015 #

Patch Set 3 : Tue Feb 24 17:29:16 PST 2015 #

Patch Set 4 : Tue Feb 24 17:30:57 PST 2015 #

Total comments: 2

Patch Set 5 : Tue Feb 24 17:40:14 PST 2015 #

Patch Set 6 : Tue Feb 24 23:11:53 PST 2015 #

Messages

Total messages: 14 (6 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-25 01:13:19 UTC) #2
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/959503003/diff/60001/chrome/browser/local_discovery/privet_http_asynchronous_factory.h File chrome/browser/local_discovery/privet_http_asynchronous_factory.h (right): https://codereview.chromium.org/959503003/diff/60001/chrome/browser/local_discovery/privet_http_asynchronous_factory.h#newcode21 chrome/browser/local_discovery/privet_http_asynchronous_factory.h:21: class ServiceDiscoverySharedClient; Why do you need this declaration ...
5 years, 10 months ago (2015-02-25 01:35:38 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/959503003/diff/60001/chrome/browser/local_discovery/privet_http_asynchronous_factory.h File chrome/browser/local_discovery/privet_http_asynchronous_factory.h (right): https://codereview.chromium.org/959503003/diff/60001/chrome/browser/local_discovery/privet_http_asynchronous_factory.h#newcode21 chrome/browser/local_discovery/privet_http_asynchronous_factory.h:21: class ServiceDiscoverySharedClient; On 2015/02/25 01:35:38, Aleksey Shlyapnikov wrote: > ...
5 years, 10 months ago (2015-02-25 01:37:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959503003/80001
5 years, 10 months ago (2015-02-25 01:41:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/29054)
5 years, 10 months ago (2015-02-25 05:35:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959503003/100001
5 years, 10 months ago (2015-02-25 07:13:17 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-25 09:47:22 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 09:48:06 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e61a6220ca4341f7eafac6dc3aacaa6f80a89896
Cr-Commit-Position: refs/heads/master@{#318013}

Powered by Google App Engine
This is Rietveld 408576698