Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 959503002: BrowserCdmManager: Do not pass MIME types as init_data_type. (Closed)

Created:
5 years, 10 months ago by ddorwin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BrowserCdmManager: Do not pass MIME types as init_data_type. This CL cleans up BrowserCdmManager, but we still need to pass a MIME type string when calling MediaKeys. This CL also fixes the name of the CdmHostMsg_CreateSession_InitDataType values. Committed: https://crrev.com/58bb64872530552023e86e62ed14de9d2a9691f9 Cr-Commit-Position: refs/heads/master@{#318106}

Patch Set 1 #

Patch Set 2 : _LAST > _MAX to be consistent with most media/ code. #

Patch Set 3 : Add USE_PROPRIETARY_CODECS guards to fix Android GN build (see crbug.com/461901). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -24 lines) Patch
M content/browser/media/cdm/browser_cdm_manager.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 2 6 chunks +31 lines, -16 lines 0 comments Download
M content/common/media/cdm_messages.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/cdm_messages_enums.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/proxy_media_keys.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ddorwin
This is some Android-specific cleanup and pre-work for crbug.com/417440.
5 years, 10 months ago (2015-02-24 22:51:24 UTC) #2
sandersd (OOO until July 31)
lgtm
5 years, 10 months ago (2015-02-24 23:05:17 UTC) #3
ddorwin
nasko@chromium.org: Please review the simple enum value renames in content/common/media/*
5 years, 10 months ago (2015-02-24 23:12:21 UTC) #5
nasko
LGTM
5 years, 10 months ago (2015-02-25 15:16:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959503002/20001
5 years, 10 months ago (2015-02-25 18:20:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959503002/40001
5 years, 10 months ago (2015-02-25 19:34:31 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 20:38:12 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:39:30 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/58bb64872530552023e86e62ed14de9d2a9691f9
Cr-Commit-Position: refs/heads/master@{#318106}

Powered by Google App Engine
This is Rietveld 408576698