Adding source code to RetrieveSymbols for PE/PDB retrieval.

Adding source code to RetrieveSymbols for PE/PDB retrieval.

This tool is helpful when diagnosing symbol server problems. It is not
part of the Chromium build. Load the solution file into Visual Studio
2013 to build this tool. See ReadMe.txt for details, or this blog post:
https://randomascii.wordpress.com/2013/03/09/symbols-the-microsoft-way/

Committed: https://crrev.com/4e27d61611ddfeb38ee5be1d8bf25743d8bd662e
Cr-Commit-Position: refs/heads/master@{#317951}

[brucedawson, 2015-02-24 22:17:48]

brucedawson@chromium.org changed reviewers:
+ zturner@chromium.org

[brucedawson, 2015-02-24 22:17:48]

Three months ago we discussed the best place to put tiny tools. I want to start
checking them in, so here's the first one.

I could also put them on my personal github account, which would make them more
accessible to people outside of Chrome, but less accessible to people inside.
Hmmm. Quandaries. Any thoughts?

[zturner, 2015-02-24 23:52:09]

On 2015/02/24 22:17:48, brucedawson wrote:
> Three months ago we discussed the best place to put tiny tools. I want to
start
> checking them in, so here's the first one.
> 
> I could also put them on my personal github account, which would make them
more
> accessible to people outside of Chrome, but less accessible to people inside.
> Hmmm. Quandaries. Any thoughts?

Looks pretty good.  Incidentally, I spent the last 2-3 weeks writing a library
around DIA in LLVM which will eventually be used by LLD and LLDB.  I'm not sure
what the rest of your tools do, although I wonder if there's some potential
overlap or possibilities for code reuse or cross-collaboration.  Although like
you said, it is kind of annoyance for someone working on Chromium to have to
depend on an external repository.

You can see the dumper I've been working on here in case you're interested:
https://github.com/llvm-mirror/llvm/tree/master/tools/llvm-pdbdump

[zturner, 2015-02-24 23:53:07]

Forgot how this thing works.  I have to hit m to publish my comments :)

lgtm

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
File tools/win/RetrieveSymbols/RetrieveSymbols.cpp (right):

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:9: #include "stdio.h"
Minor nit: any reason you chose to use quote syntax here?

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:37: std::string gText =
"072FF0EB54D24DFAAE9D13885486EE09";
Is this supposed to be called gTextArg?  Looks like it won't compile as is with
TESTING

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:87: std::string gText;
How about GUIDFromString()?  Removes almost this entire if branch.

[brucedawson, 2015-02-25 00:15:22]

Comments (mostly) addressed.

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
File tools/win/RetrieveSymbols/RetrieveSymbols.cpp (right):

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:9: #include "stdio.h"
Copy paste error I think. Fixed.

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:37: std::string gText =
"072FF0EB54D24DFAAE9D13885486EE09";
Good catch. I fixed that and verified that the TESTING version compiles and
works correctly now.

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:87: std::string gText;
I looked at that function before and it seemed... problematic. The documentation
says it isn't exported or declared and may disappear. And those functions seem
to have very strict formatting requirements, which takes some of the fun out of
it.

It is odd that there isn't a trivially available, well documented, powerful and
flexible way to handle this operation.

[zturner, 2015-02-25 00:29:33]

lgtm

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
File tools/win/RetrieveSymbols/RetrieveSymbols.cpp (right):

https://codereview.chromium.org/959483002/diff/1/tools/win/RetrieveSymbols/Re...
tools/win/RetrieveSymbols/RetrieveSymbols.cpp:87: std::string gText;
On 2015/02/25 00:15:22, brucedawson wrote:
> I looked at that function before and it seemed... problematic. The
documentation
> says it isn't exported or declared and may disappear. And those functions seem
> to have very strict formatting requirements, which takes some of the fun out
of
> it.
> 
> It is odd that there isn't a trivially available, well documented, powerful
and
> flexible way to handle this operation.

Ahh yea, I didn't notice that.  There's CLSIDFromString, but then you have to do
a wide char conversion.  Bleh.

[brucedawson, 2015-02-25 00:30:26]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-02-25 00:31:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959483002/20001

[commit-bot: I haz the power, 2015-02-25 01:57:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-25 01:58:21]

Patchset 2 (id:??) landed as
https://crrev.com/4e27d61611ddfeb38ee5be1d8bf25743d8bd662e
Cr-Commit-Position: refs/heads/master@{#317951}