Roll Clang 223108:230631 (+revert of r229678)

Roll Clang 223108:230631 (+revert of r229678)

Also introduce a build number in the package name, stop versioning
the Blink GC plugin, and remove repackage.sh.

BUG=444089
TBR=jln, jbauman
NOPRESUBMIT=true

Committed: https://crrev.com/b8be3a268134f32d667b42ea60a27c0084063873
Cr-Commit-Position: refs/heads/master@{#318610}

[hans, 2015-02-25 00:00:03]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2015-02-25 00:00:04]

This is the same as https://codereview.chromium.org/881763003/, with a new Clang
revision.

[Nico, 2015-02-25 00:01:26]

lgtm, knock on wood

[hans, 2015-02-25 00:02:34]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-02-25 00:02:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959443002/1

[commit-bot: I haz the power, 2015-02-25 04:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 04:21:00]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2015-02-25 04:25:29]

../../mojo/services/html_viewer/ax_provider_impl_unittest.cc:55:3:error:
[chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
  virtual ~AxProviderImplTest() override { blink::shutdown(); }

I'll try to get it.

[Nico, 2015-02-25 04:48:57]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-02-25 04:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959443002/1

[commit-bot: I haz the power, 2015-02-25 13:55:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 13:55:44]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2015-02-25 14:51:45]

On 2015/02/25 13:55:44, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like that might be real.

[Nico, 2015-02-28 21:10:30]

https://codereview.chromium.org/959443002/diff/40001/tools/clang/scripts/upda...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/959443002/diff/40001/tools/clang/scripts/upda...
tools/clang/scripts/update.sh:96: echo $CLANG_REVISION
This should probably return PACKAGE_VERSION now, so that plugin-only changes (or
cherrypick-only changes) cause full rebuilds too, right?

[hans, 2015-02-28 22:01:06]

https://codereview.chromium.org/959443002/diff/40001/tools/clang/scripts/upda...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/959443002/diff/40001/tools/clang/scripts/upda...
tools/clang/scripts/update.sh:96: echo $CLANG_REVISION
On 2015/02/28 21:10:30, Nico wrote:
> This should probably return PACKAGE_VERSION now, so that plugin-only changes
(or
> cherrypick-only changes) cause full rebuilds too, right?

Nice catch! Yes, absolutely. Done.

[Nico, 2015-02-28 22:04:00]

lgtm with green android_clang runs. Not sure if any bot we have will run into
the android crash pcc filed? Worst case we'll have to revert the roll. (And
maybe we'll learn about more revert reasons if we cq this.)

[hans, 2015-02-28 22:09:40]

On 2015/02/28 22:04:00, Nico wrote:
> Not sure if any bot we have will run into
> the android crash pcc filed? Worst case we'll have to revert the roll. (And
> maybe we'll learn about more revert reasons if we cq this.)

We'll find out. I think it's a good idea to roll this in and see what the bots
say.

[hans, 2015-02-28 22:09:49]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-02-28 22:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959443002/60001

[commit-bot: I haz the power, 2015-02-28 22:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 22:14:23]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[hans, 2015-02-28 22:22:56]

The CQ bit was checked by hans@chromium.org

[hans, 2015-02-28 22:22:56]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/959443002/#ps80001 (title:
"Variable names are hard")

[commit-bot: I haz the power, 2015-02-28 22:23:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959443002/80001

[commit-bot: I haz the power, 2015-03-01 00:55:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-01 00:56:08]

Patchset 5 (id:??) landed as
https://crrev.com/b8be3a268134f32d667b42ea60a27c0084063873
Cr-Commit-Position: refs/heads/master@{#318610}

[hans, 2015-03-01 02:25:26]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/970623002/ by hans@chromium.org.

The reason for reverting is: Linux Chrome build is broken:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%....