extensions/browser/extension_function_histogram_value.h - Issue 959413003: Implement <webview>.addContentScript/removeContentScript API [1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function_histogram_value.h

Issue 959413003: Implement <webview>.addContentScript/removeContentScript API [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Devlin's comments and fix the incognito mode issue. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/guest_view/web_view/web_view_internal_api.cc ('K') | « extensions/browser/api/guest_view/web_view/web_view_internal_api.cc ('k') | extensions/browser/guest_view/guest_view_message_filter.h » ('j') | extensions/browser/guest_view/web_view/web_view_content_script_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function_histogram_value.h

diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h

index 3eb1b9919ecb4aaffd4398b80bb1d8afbb5da4ab..1b6b58a17596047ad51accd609adda0a18e41bd7 100644

--- a/extensions/browser/extension_function_histogram_value.h

+++ b/extensions/browser/extension_function_histogram_value.h

@@ -1057,6 +1057,8 @@ enum HistogramValue {

DATAREDUCTIONPROXY_CLEARDATASAVINGS,

BLUETOOTHPRIVATE_SETDISCOVERYFILTER,

FILESYSTEM_GETVOLUMELIST,

+ WEBVIEWINTERNAL_ADDCONTENTSCRIPTS,

+ WEBVIEWINTERNAL_REMOVECONTENTSCRIPTS,

// Last entry: Add new entries above and ensure to update

// tools/metrics/histograms/histograms.xml.

ENUM_BOUNDARY