Issue 959393002: Add chrome driver to the GN build.

Issue 959393002: Add chrome driver to the GN build. (Closed)

Created:
5 years, 9 months ago by brettw

Modified:
5 years, 9 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, samuong+watch_chromium.org, stgao

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add chrome driver to the GN build. Reland of https://codereview.chromium.org/958743003/ TBR=dpranke Committed: https://crrev.com/922d3aaed68d13ef28eaf9f927d92f4832197880 Cr-Commit-Position: refs/heads/master@{#318529}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+343 lines, -83 lines)			Patch
M	BUILD.gn	View	1	5 chunks	+6 lines, -3 lines	0 comments	Download
A	chrome/chrome_tests.gni	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		11 chunks	+17 lines, -8 lines	0 comments	Download
M	chrome/test/BUILD.gn	View		16 chunks	+86 lines, -72 lines	0 comments	Download
A	chrome/test/chromedriver/BUILD.gn	View		1 chunk	+224 lines, -0 lines	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959393002/1

5 years, 9 months ago (2015-02-27 20:32:03 UTC) #4

brettw

I removed chrome driver from the Android build. I suspect this was the problem.

5 years, 9 months ago (2015-02-27 21:24:07 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959393002/20001

5 years, 9 months ago (2015-02-27 21:25:14 UTC) #8

commit-bot: I haz the power

5 years, 9 months ago (2015-02-27 22:16:51 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/922d3aaed68d13ef28eaf9f927d92f4832197880
Cr-Commit-Position: refs/heads/master@{#318529}