Enable new sync URL to link to Chrome Away

[Sync]Enable new  sync URL to link to Chrome Away

Current string: Signed in as [email]. Manage your synced data and devices on Google Dashboard.
New strings: Signed in as [email]. Manage your synced data and devices on chrome.com/sync

BUG=402615
Manual test:
launch chrome by chrome --force-fieldtrials="ChromeDashboard/Enabled/"
log in chrome, and then go to settings, on the top of settings, there should be the new string, click the "chrome.com/sync", it should bring you to new URL(chrome.com/sync).

Committed: https://crrev.com/fa518c3b6b98ef6563d826e7b980fc8dde3e8086
Cr-Commit-Position: refs/heads/master@{#319550}

[Gang Wu, 2015-02-27 18:33:48]

gangwu@chromium.org changed reviewers:
+ rpop@chromium.org, zea@chromium.org

[Gang Wu, 2015-02-27 18:34:03]

please take a look

[Nicolas Zea, 2015-02-27 19:06:07]

https://codereview.chromium.org/959343003/diff/1/chrome/browser/sync/sync_ui_...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/959343003/diff/1/chrome/browser/sync/sync_ui_...
chrome/browser/sync/sync_ui_util.cc:92:
IDS_SYNC_ACCOUNT_SYNCING_TO_USER_WITH_MANAGE_LINK_NEW,
is the old string used anywhere?

https://codereview.chromium.org/959343003/diff/1/chrome/common/url_constants.h
File chrome/common/url_constants.h (right):

https://codereview.chromium.org/959343003/diff/1/chrome/common/url_constants....
chrome/common/url_constants.h:350: extern const char kSyncGoogleDashboardURL[];
do we still use this anywhere?

[Gang Wu, 2015-03-05 20:36:24]

Patchset #2 (id:20001) has been deleted

[Gang Wu, 2015-03-05 20:40:31]

update after discuss with Rachel

https://codereview.chromium.org/959343003/diff/1/chrome/browser/sync/sync_ui_...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/959343003/diff/1/chrome/browser/sync/sync_ui_...
chrome/browser/sync/sync_ui_util.cc:92:
IDS_SYNC_ACCOUNT_SYNCING_TO_USER_WITH_MANAGE_LINK_NEW,
On 2015/02/27 19:06:07, Nicolas Zea wrote:
> is the old string used anywhere?

update the CL, and yes, we need it

https://codereview.chromium.org/959343003/diff/1/chrome/common/url_constants.h
File chrome/common/url_constants.h (right):

https://codereview.chromium.org/959343003/diff/1/chrome/common/url_constants....
chrome/common/url_constants.h:350: extern const char kSyncGoogleDashboardURL[];
On 2015/02/27 19:06:07, Nicolas Zea wrote:
> do we still use this anywhere?

update CL, after update, it is clear that we still need it

[Gang Wu, 2015-03-05 20:53:05]

Patchset #2 (id:40001) has been deleted

[Gang Wu, 2015-03-05 21:17:21]

gangwu@chromium.org changed reviewers:
+ jwd@chromium.org

[Nicolas Zea, 2015-03-05 21:41:35]

LGTM with two nits

https://codereview.chromium.org/959343003/diff/60001/chrome/browser/sync/sync...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/959343003/diff/60001/chrome/browser/sync/sync...
chrome/browser/sync/sync_ui_util.cc:46: bool IsChromeAwayFromChromeEnabled() {
nit: use IsChromeDashboardEnabled instead

https://codereview.chromium.org/959343003/diff/60001/chrome/browser/sync/sync...
chrome/browser/sync/sync_ui_util.cc:48:
base::FieldTrialList::FindFullName("ChromeDashboard");
It's good style to #include any libraries you depend on directly,
"field_trial.h" in this case (include what you use)

[jwd, 2015-03-06 21:50:18]

LGTM for field trial setup.

[Gang Wu, 2015-03-06 21:58:43]

The CQ bit was checked by gangwu@chromium.org

[Gang Wu, 2015-03-06 21:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/959343003/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-03-06 21:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959343003/80001

[commit-bot: I haz the power, 2015-03-07 00:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 00:00:07]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[Gang Wu, 2015-03-07 00:19:11]

The CQ bit was checked by gangwu@chromium.org

[commit-bot: I haz the power, 2015-03-07 00:21:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959343003/80001

[commit-bot: I haz the power, 2015-03-07 03:15:46]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-03-07 03:16:51]

Patchset 3 (id:??) landed as
https://crrev.com/fa518c3b6b98ef6563d826e7b980fc8dde3e8086
Cr-Commit-Position: refs/heads/master@{#319550}