Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 959313002: Stage ES6 computed property names (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage ES6 computed property names BUG=v8:3754 LOG=N R=dslomov@chromium.org, rossberg@chromium.org Committed: https://crrev.com/9ac336f2172bf330bd9dfe65f6cd6ed9f3a2ab0b Cr-Commit-Position: refs/heads/master@{#26922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-02-27 17:25:33 UTC) #1
adamk
lgtm, this got the thumbs-up in the language team meeting.
5 years, 9 months ago (2015-02-27 17:36:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959313002/1
5 years, 9 months ago (2015-02-27 17:37:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 18:09:40 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 18:09:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ac336f2172bf330bd9dfe65f6cd6ed9f3a2ab0b
Cr-Commit-Position: refs/heads/master@{#26922}

Powered by Google App Engine
This is Rietveld 408576698