Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 959303002: Move some feature flags to declare_args() so features can be disabled (Closed)

Created:
5 years, 9 months ago by Tomasz Moniuszko
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some feature flags to declare_args() so features can be disabled BUG= Committed: https://crrev.com/c5a066f4e516b6dd295ccb3e460ee39ee0f3abd2 Cr-Commit-Position: refs/heads/master@{#318668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M build/config/features.gni View 4 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tomasz Moniuszko
5 years, 9 months ago (2015-02-27 15:56:19 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-02-27 21:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959303002/1
5 years, 9 months ago (2015-03-02 08:13:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 08:46:15 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 08:46:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5a066f4e516b6dd295ccb3e460ee39ee0f3abd2
Cr-Commit-Position: refs/heads/master@{#318668}

Powered by Google App Engine
This is Rietveld 408576698