Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: src/profile-generator.h

Issue 959203002: CpuProfiler: replace raw position with SourcePosition for DeoptReason (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix for win32 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ppc/lithium-codegen-ppc.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 08e4afd6ca49bda73c5e7529f3e92aa8114db69d..7ea168bcdafbb3f1994dfc16e9d4eaf8f11698c7 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -8,6 +8,7 @@
#include <map>
#include "include/v8-profiler.h"
#include "src/allocation.h"
+#include "src/compiler.h"
#include "src/hashmap.h"
#include "src/strings-storage.h"
@@ -64,17 +65,17 @@ class CodeEntry {
}
const char* bailout_reason() const { return bailout_reason_; }
- void set_deopt_info(const char* deopt_reason, int location) {
- DCHECK(!deopt_location_);
+ void set_deopt_info(const char* deopt_reason, SourcePosition position) {
+ DCHECK(deopt_position_.IsUnknown());
deopt_reason_ = deopt_reason;
- deopt_location_ = location;
+ deopt_position_ = position;
}
const char* deopt_reason() const { return deopt_reason_; }
- int deopt_location() const { return deopt_location_; }
- bool has_deopt_info() const { return deopt_location_; }
+ SourcePosition deopt_position() const { return deopt_position_; }
+ bool has_deopt_info() const { return !deopt_position_.IsUnknown(); }
void clear_deopt_info() {
deopt_reason_ = kNoDeoptReason;
- deopt_location_ = 0;
+ deopt_position_ = SourcePosition::Unknown();
}
void FillFunctionInfo(SharedFunctionInfo* shared);
@@ -119,7 +120,7 @@ class CodeEntry {
List<OffsetRange>* no_frame_ranges_;
const char* bailout_reason_;
const char* deopt_reason_;
- int deopt_location_;
+ SourcePosition deopt_position_;
JITLineInfoTable* line_info_;
Address instruction_start_;
@@ -132,13 +133,13 @@ class ProfileTree;
class ProfileNode {
private:
struct DeoptInfo {
- DeoptInfo(const char* deopt_reason, int deopt_location)
- : deopt_reason(deopt_reason), deopt_location(deopt_location) {}
+ DeoptInfo(const char* deopt_reason, SourcePosition deopt_position)
+ : deopt_reason(deopt_reason), deopt_position(deopt_position) {}
DeoptInfo(const DeoptInfo& info)
: deopt_reason(info.deopt_reason),
- deopt_location(info.deopt_location) {}
+ deopt_position(info.deopt_position) {}
const char* deopt_reason;
- int deopt_location;
+ SourcePosition deopt_position;
};
public:
« no previous file with comments | « src/ppc/lithium-codegen-ppc.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698