Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/profile-generator.cc

Issue 959203002: CpuProfiler: replace raw position with SourcePosition for DeoptReason (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix for win32 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profile-generator.h ('k') | src/profile-generator-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 656da1e97e0f333fd6c376819549d9191f3efb8b..d030b681ec669b1d7e99ed26751fd23e0899a59a 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -113,7 +113,7 @@ void CodeEntry::FillFunctionInfo(SharedFunctionInfo* shared) {
void ProfileNode::CollectDeoptInfo(CodeEntry* entry) {
- deopt_infos_.Add(DeoptInfo(entry->deopt_reason(), entry->deopt_location()));
+ deopt_infos_.Add(DeoptInfo(entry->deopt_reason(), entry->deopt_position()));
entry->clear_deopt_info();
}
@@ -182,8 +182,14 @@ void ProfileNode::Print(int indent) {
base::OS::Print(" %s:%d", entry_->resource_name(), entry_->line_number());
base::OS::Print("\n");
for (auto info : deopt_infos_) {
- base::OS::Print("%*s deopted at %d with reason '%s'\n", indent + 10, "",
- info.deopt_location, info.deopt_reason);
+ if (FLAG_hydrogen_track_positions) {
+ base::OS::Print("%*s deopted at %d_%d with reason '%s'\n", indent + 10,
+ "", info.deopt_position.inlining_id(),
+ info.deopt_position.position(), info.deopt_reason);
+ } else {
+ base::OS::Print("%*s deopted at %d with reason '%s'\n", indent + 10, "",
+ info.deopt_position.raw(), info.deopt_reason);
+ }
}
const char* bailout_reason = entry_->bailout_reason();
if (bailout_reason != GetBailoutReason(BailoutReason::kNoReason) &&
« no previous file with comments | « src/profile-generator.h ('k') | src/profile-generator-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698