CpuProfiler: replace raw position with SourcePosition for DeoptReason

CpuProfiler: replace raw position with SourcePosition for DeoptReason

Save Unknown position as zero in RelocInfo.
Remove copy constructor of SourcePosition because it is trivial.
Mechanical replace int raw_position with SourcePosition position.

BUG=452067
LOG=n

Committed: https://crrev.com/32ee9fa6ab08e9cafceae3f148cd6ec52306be64
Cr-Commit-Position: refs/heads/master@{#26916}

[loislo, 2015-02-27 10:14:40]

loislo@chromium.org changed reviewers:
+ alph@chromium.org, svenpanne@chromium.org, yurys@chromium.org

[loislo, 2015-02-27 10:14:40]

PTAL

[yurys, 2015-02-27 10:35:24]

https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc#newcode...
src/assembler.cc:1663: int raw_position = position.IsUnknown() ? 0 :
position.raw();
Can we change SourcePosition so that raw() value of SourcePosition::Unknown() is
0 and avoid this code? Otherwise we rely on the fact that position.raw() cannot
return 0 which is non-obvious.

https://codereview.chromium.org/959203002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/959203002/diff/20001/src/objects.cc#newcode11269
src/objects.cc:11269: if (info.deopt_reason != Deoptimizer::kNoReason ||
pos.raw() != 0) {
 pos.raw() != 0 ==> !pos.IsUnknown()

[loislo, 2015-02-27 12:04:28]

comments addressed

https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc#newcode...
src/assembler.cc:1663: int raw_position = position.IsUnknown() ? 0 :
position.raw();
On 2015/02/27 10:35:24, yurys wrote:
> Can we change SourcePosition so that raw() value of SourcePosition::Unknown()
is
> 0 and avoid this code? Otherwise we rely on the fact that position.raw()
cannot
> return 0 which is non-obvious.

We use RelocInfo::kNoPosition in many other places, so it'd be non-trivial to
fix. I'd rather do this in another patch.

https://codereview.chromium.org/959203002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/959203002/diff/20001/src/objects.cc#newcode11269
src/objects.cc:11269: if (info.deopt_reason != Deoptimizer::kNoReason ||
pos.raw() != 0) {
On 2015/02/27 10:35:24, yurys wrote:
>  pos.raw() != 0 ==> !pos.IsUnknown()

Done.

[yurys, 2015-02-27 12:25:16]

lgtm

[Sven Panne, 2015-02-27 13:32:41]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-02-27 13:32:42]

lgtm

[Sven Panne, 2015-02-27 13:32:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/959203002/#ps80001 (title:
"fix for win32")

[commit-bot: I haz the power, 2015-02-27 13:33:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959203002/80001

[commit-bot: I haz the power, 2015-02-27 13:34:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-27 13:34:52]

Patchset 5 (id:??) landed as
https://crrev.com/32ee9fa6ab08e9cafceae3f148cd6ec52306be64
Cr-Commit-Position: refs/heads/master@{#26916}