Issue 959123004: Remove usage of WebContents::GetURL from speech recognition test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 959123004: Remove usage of WebContents::GetURL from speech recognition test. (Closed)

Created:
5 years, 9 months ago by nasko

Modified:
5 years, 9 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove usage of WebContents::GetURL from speech recognition test. BUG=273710 Committed: https://crrev.com/2cee8dd7655a7ec82a8ce6f7b30f984d1e498d93 Cr-Commit-Position: refs/heads/master@{#318818}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/speech/speech_recognition_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

nasko

Hey Charlie, I'm trying to resume the whacking of WebContents::GetURL and this is the first ...

5 years, 9 months ago (2015-03-03 00:40:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959123004/1

5 years, 9 months ago (2015-03-03 00:45:23 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-03 02:42:03 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2cee8dd7655a7ec82a8ce6f7b30f984d1e498d93
Cr-Commit-Position: refs/heads/master@{#318818}