Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 959073002: Fix new line breaks on } (Closed)

Created:
5 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 10 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1296 lines, -1502 lines) Patch
M lib/devc.dart View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/codegen/dart_codegen.dart View 1 2 3 5 chunks +40 lines, -18 lines 0 comments Download
M lib/src/options.dart View 1 2 3 2 chunks +10 lines, -6 lines 0 comments Download
M test/codegen_test.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/dart_codegen/expect/_internal/iterable.dart View 1 2 18 chunks +55 lines, -99 lines 0 comments Download
M test/dart_codegen/expect/_internal/list.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/_internal/lists.dart View 1 2 5 chunks +8 lines, -19 lines 0 comments Download
M test/dart_codegen/expect/_internal/sort.dart View 1 2 4 chunks +4 lines, -12 lines 0 comments Download
M test/dart_codegen/expect/async/async_error.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/async/broadcast_stream_controller.dart View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M test/dart_codegen/expect/collection/iterable.dart View 1 2 12 chunks +209 lines, -218 lines 0 comments Download
M test/dart_codegen/expect/collection/list.dart View 1 2 17 chunks +19 lines, -57 lines 0 comments Download
M test/dart_codegen/expect/collection/queue.dart View 1 2 4 chunks +4 lines, -12 lines 0 comments Download
M test/dart_codegen/expect/collection/set.dart View 1 chunk +84 lines, -87 lines 0 comments Download
M test/dart_codegen/expect/convert/ascii.dart View 1 2 6 chunks +6 lines, -18 lines 0 comments Download
M test/dart_codegen/expect/convert/html_escape.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 1 2 10 chunks +11 lines, -33 lines 0 comments Download
M test/dart_codegen/expect/convert/latin1.dart View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/convert/string_conversion.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 1 2 6 chunks +8 lines, -17 lines 0 comments Download
M test/dart_codegen/expect/core/date_time.dart View 1 chunk +54 lines, -67 lines 0 comments Download
M test/dart_codegen/expect/core/duration.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M test/dart_codegen/expect/core/errors.dart View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/exceptions.dart View 1 2 3 chunks +18 lines, -25 lines 0 comments Download
M test/dart_codegen/expect/core/list.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 1 2 6 chunks +739 lines, -766 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
here is a second attempt
5 years, 10 months ago (2015-02-26 22:26:16 UTC) #1
Leaf
lgtm, thanks!
5 years, 10 months ago (2015-02-26 22:32:30 UTC) #2
Siggi Cherem (dart-lang)
5 years, 10 months ago (2015-02-26 22:32:53 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
59ef7e900dfc83c852463f2f3e6852d8a0448ae3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698