Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/perf/page_sets/key_mobile_sites_smooth.py

Issue 959063002: key_mobile_sites_smooth: Reload pages before scrolling for LinkedIn and Wowwiki (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lets do navigate->scroll->reload->navigate->scroll Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_mobile_sites_smooth.py
diff --git a/tools/perf/page_sets/key_mobile_sites_smooth.py b/tools/perf/page_sets/key_mobile_sites_smooth.py
index 918e46ddcddf911e16e733b5e51637addf9aa090..7fabcd9ec5138b9346bd6a51e74a5e127b285df2 100644
--- a/tools/perf/page_sets/key_mobile_sites_smooth.py
+++ b/tools/perf/page_sets/key_mobile_sites_smooth.py
@@ -40,6 +40,36 @@ class KeyMobileSitesSmoothPage(page_module.Page):
_IssueMarkerAndScroll(action_runner)
+class LinkedInSmoothPage(key_mobile_sites_pages.LinkedInPage):
+
+ def __init__(self, page_set):
+ super(LinkedInSmoothPage, self).__init__(page_set=page_set)
+
+ # Linkedin has expensive shader compilation so it can benefit from shader
+ # cache from reload.
+ def RunNavigateSteps(self, action_runner):
+ super(LinkedInSmoothPage, self).RunNavigateSteps(action_runner)
+ action_runner.ScrollPage()
+ action_runner.ReloadPage()
+ super(LinkedInSmoothPage, self).RunNavigateSteps(action_runner)
+
+
+class WowwikiSmoothPage(KeyMobileSitesSmoothPage):
+ """# Why: Mobile wiki."""
nednguyen 2015/03/03 19:16:41 You don't need the "#" here
Yufeng Shen (Slow to review) 2015/03/03 19:22:54 Done.
+ def __init__(self, page_set):
+ super(WowwikiSmoothPage, self).__init__(
+ url='http://www.wowwiki.com/World_of_Warcraft:_Mists_of_Pandaria',
+ page_set=page_set)
+
+ # Wowwiki has expensive shader compilation so it can benefit from shader
+ # cache from reload.
+ def RunNavigateSteps(self, action_runner):
+ super(WowwikiSmoothPage, self).RunNavigateSteps(action_runner)
+ action_runner.ScrollPage()
+ action_runner.ReloadPage()
+ super(WowwikiSmoothPage, self).RunNavigateSteps(action_runner)
+
+
class GmailSmoothPage(key_mobile_sites_pages.GmailPage):
def RunPageInteractions(self, action_runner):
@@ -129,7 +159,6 @@ class KeyMobileSitesSmoothPageSet(page_set_module.PageSet):
key_mobile_sites_pages.CnnArticlePage,
key_mobile_sites_pages.FacebookPage,
key_mobile_sites_pages.YoutubeMobilePage,
- key_mobile_sites_pages.LinkedInPage,
key_mobile_sites_pages.YahooAnswersPage,
key_mobile_sites_pages.GoogleNewsMobilePage,
]
@@ -137,6 +166,10 @@ class KeyMobileSitesSmoothPageSet(page_set_module.PageSet):
self.AddUserStory(
_CreatePageClassWithSmoothInteractions(page_class)(self))
+ self.AddUserStory(
+ _CreatePageClassWithSmoothInteractions(LinkedInSmoothPage)(self))
+ self.AddUserStory(WowwikiSmoothPage(self))
+
# Add pages with custom page interaction logic.
# Page behaves non-deterministically, replaced with test version for now.
@@ -253,8 +286,6 @@ class KeyMobileSitesSmoothPageSet(page_set_module.PageSet):
'http://www.sfgate.com/',
# Why: Non-latin character set
'http://worldjournal.com/',
- # Why: Mobile wiki
- 'http://www.wowwiki.com/World_of_Warcraft:_Mists_of_Pandaria',
# Why: #15 Alexa news
'http://online.wsj.com/home-page',
# Why: Image-heavy mobile site
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698