Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 959053003: Revert of Show Autofill/Wallet options only when signed in. (Closed)

Created:
5 years, 10 months ago by stevenjb
Modified:
5 years, 10 months ago
Reviewers:
brettw, Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, michaelpg+watch-options_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show Autofill/Wallet options only when signed in. (patchset #3 id:40001 of https://codereview.chromium.org/950003002/) Reason for revert: Crash in browser tests on Chrome OS crbug.com/462408 Original issue's description: > Show Autofill/Wallet options only when signed in. > > Before this patch, you could still see the options if you signed into a whitelisted account (setting the sync experiment preference) and then signed out of the account. > > BUG=none > R=brettw@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/c50285a99bc5523ea4ccdaa372a721695fb16b53 TBR=brettw@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/c89ecfaa3468827ca1d0554053ad841c9a4e7489 Cr-Commit-Position: refs/heads/master@{#318348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
Created Revert of Show Autofill/Wallet options only when signed in.
5 years, 10 months ago (2015-02-26 23:28:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959053003/1
5 years, 10 months ago (2015-02-26 23:28:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 23:30:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c89ecfaa3468827ca1d0554053ad841c9a4e7489 Cr-Commit-Position: refs/heads/master@{#318348}
5 years, 10 months ago (2015-02-26 23:31:19 UTC) #4
Evan Stade
5 years, 10 months ago (2015-02-27 00:09:20 UTC) #5
Message was sent while issue was closed.
On 2015/02/26 23:31:19, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c89ecfaa3468827ca1d0554053ad841c9a4e7489
> Cr-Commit-Position: refs/heads/master@{#318348}

lgtm, sorry

Powered by Google App Engine
This is Rietveld 408576698