Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 959033004: Remove ClientLogin support from remoting host (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 9 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ClientLogin support from remoting host All hosts should be using OAuth2 now, so ClientLogin support can be removed. BUG=446646, 83897 Committed: https://crrev.com/d61f007c70ed45fa94b3e67fa0e991d511fd79a0 Cr-Commit-Position: refs/heads/master@{#318716}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -170 lines) Patch
D remoting/base/auth_token_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D remoting/base/auth_token_util.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D remoting/base/auth_token_util_unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M remoting/base/constants.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/base/constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_config.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/host_config_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/host_config_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/host_signaling_manager.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M remoting/host/signaling_connector.h View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/host/signaling_connector.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/signaling/xmpp_signal_strategy.h View 2 chunks +1 line, -3 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Sergey Ulanov
5 years, 10 months ago (2015-02-27 01:23:47 UTC) #2
rmsousa
lgtm
5 years, 9 months ago (2015-02-28 00:05:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959033004/20001
5 years, 9 months ago (2015-02-28 05:33:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/843)
5 years, 9 months ago (2015-02-28 05:38:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959033004/20001
5 years, 9 months ago (2015-02-28 07:13:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/848)
5 years, 9 months ago (2015-02-28 07:18:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959033004/20001
5 years, 9 months ago (2015-03-02 16:38:09 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 17:21:37 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:22:04 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d61f007c70ed45fa94b3e67fa0e991d511fd79a0
Cr-Commit-Position: refs/heads/master@{#318716}

Powered by Google App Engine
This is Rietveld 408576698