Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 959033002: Making Chromoting use no GPO provider in PolicyLoaderWin. (Closed)

Created:
5 years, 9 months ago by Jamie
Modified:
5 years, 9 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Making Chromoting use no GPO provider in PolicyLoaderWin. The old Chromoting code (policy_hack before crrev.com/830193002) used to always read Chromoting policies from the registry. The new code (using components/policy) ignores contents of the registry on non-domain-joined machines. This old-vs-new difference in behavior was unintentional. The current changelist ensures that Chromoting's old behavior is preserved. BUG=460734 TEST=1) components_unittests.exe, 2) remoting_unittests.exe, 3) remoting_unittests.exe --gtest_filter=*PolicyWatcher*Real* -v=1 copied and run from a non-domain-joined, test VM to verify that Chromoting gets its policies from the registry (HKLM\SOFTWARE\Policies\Google\Chrome) in this scenario. Review URL: https://codereview.chromium.org/947353002 Cr-Commit-Position: refs/heads/master@{#317865} (cherry picked from commit bccb49e3a1864e703a01beabaf9961f215956dea) TBR=dcaiafa Committed: https://chromium.googlesource.com/chromium/src/+/41afc827ec23ff2c52add2f25782ad97b4137f28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M components/policy/core/common/policy_loader_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M remoting/host/policy_watcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jamie
Committed patchset #1 (id:1) manually as 41afc827ec23ff2c52add2f25782ad97b4137f28 (presubmit successful).
5 years, 9 months ago (2015-02-26 20:55:23 UTC) #1
dcaiafa
5 years, 9 months ago (2015-02-26 22:52:18 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698