Issue 95903002: Enhance check_ecs_deps to allow locally built libraries.

Issue 95903002: Enhance check_ecs_deps to allow locally built libraries. (Closed)

Created:
7 years ago by Peter Mayo

Modified:
7 years ago

Reviewers:
rjkroege, Peter Mayo (wrong one), spang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enhance check_ecs_deps to allow locally built libraries. Added a verbose option so the rationality of the above can be checked. BUG=None TEST=local, and on non-static build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238272

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 7

Patch Set 3 : Fixed pylint warnings #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -15 lines)			Patch
	M	tools/check_ecs_deps/check_ecs_deps.py	View	1 2	6 chunks	+33 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

rjkroege

lgtm https://codereview.chromium.org/95903002/diff/1/tools/check_ecs_deps/check_ecs_deps.py File tools/check_ecs_deps/check_ecs_deps.py (right): https://codereview.chromium.org/95903002/diff/1/tools/check_ecs_deps/check_ecs_deps.py#newcode150 tools/check_ecs_deps/check_ecs_deps.py:150: elif built_regexp.match(source): nit: why extra spaces before lib?

7 years ago (2013-12-02 16:17:21 UTC) #2

Peter Mayo (wrong one)

https://codereview.chromium.org/95903002/diff/1/tools/check_ecs_deps/check_ecs_deps.py File tools/check_ecs_deps/check_ecs_deps.py (right): https://codereview.chromium.org/95903002/diff/1/tools/check_ecs_deps/check_ecs_deps.py#newcode150 tools/check_ecs_deps/check_ecs_deps.py:150: elif built_regexp.match(source): On 2013/12/02 16:17:22, rjkroege wrote: > nit: ...

7 years ago (2013-12-02 16:42:01 UTC) #3

spang

lgtm https://codereview.chromium.org/95903002/diff/20001/tools/check_ecs_deps/check_ecs_deps.py File tools/check_ecs_deps/check_ecs_deps.py (right): https://codereview.chromium.org/95903002/diff/20001/tools/check_ecs_deps/check_ecs_deps.py#newcode120 tools/check_ecs_deps/check_ecs_deps.py:120: built_regexp extra line?

7 years ago (2013-12-02 23:25:38 UTC) #4

Peter Mayo (wrong one)

https://codereview.chromium.org/95903002/diff/20001/tools/check_ecs_deps/check_ecs_deps.py File tools/check_ecs_deps/check_ecs_deps.py (right): https://codereview.chromium.org/95903002/diff/20001/tools/check_ecs_deps/check_ecs_deps.py#newcode9 tools/check_ecs_deps/check_ecs_deps.py:9: import getopt Unused, remove. https://codereview.chromium.org/95903002/diff/20001/tools/check_ecs_deps/check_ecs_deps.py#newcode53 tools/check_ecs_deps/check_ecs_deps.py:53: def stdmsg(final, errors): ...

7 years ago (2013-12-02 23:48:40 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/95903002/40001

7 years ago (2013-12-02 23:50:46 UTC) #6

Message was sent while issue was closed.

Change committed as 238272

Expand Messages | Collapse Messages