Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 959003002: cc: Clear the invalidation history when moving between compositors. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman, weiliangc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clear the invalidation history when moving between compositors. When a layer is moved to a new compositor, the source frame number can change non-monotonically. When this happens to PicturePile's invalidation history it DCHECKs due to this. To support PicturePile's use of the source frame number, when the source frame number's base changes we inform the PicturePile and have it reset its invalidation history. R=enne BUG=369653 Committed: https://crrev.com/5537a42c2b6bf70a9c1fa6fed5092747235f1aa4 Cr-Commit-Position: refs/heads/master@{#318326}

Patch Set 1 #

Total comments: 3

Patch Set 2 : picturemovemonitor: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M cc/layers/picture_layer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 2 chunks +54 lines, -0 lines 0 comments Download
M cc/resources/display_list_recording_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/display_list_recording_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/resources/picture_pile.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/resources/picture_pile.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/resources/recording_source.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
danakj
5 years, 10 months ago (2015-02-26 19:29:53 UTC) #1
enne (OOO)
https://codereview.chromium.org/959003002/diff/1/cc/layers/picture_layer_unittest.cc File cc/layers/picture_layer_unittest.cc (right): https://codereview.chromium.org/959003002/diff/1/cc/layers/picture_layer_unittest.cc#newcode115 cc/layers/picture_layer_unittest.cc:115: TEST(PictureLayerTest, NonMonotonicSourceFrameNumber) { How would this fail before the ...
5 years, 10 months ago (2015-02-26 20:46:04 UTC) #2
danakj
https://codereview.chromium.org/959003002/diff/1/cc/layers/picture_layer_unittest.cc File cc/layers/picture_layer_unittest.cc (right): https://codereview.chromium.org/959003002/diff/1/cc/layers/picture_layer_unittest.cc#newcode115 cc/layers/picture_layer_unittest.cc:115: TEST(PictureLayerTest, NonMonotonicSourceFrameNumber) { On 2015/02/26 20:46:04, enne wrote: > ...
5 years, 10 months ago (2015-02-26 21:10:23 UTC) #3
enne (OOO)
lgtm with a test-level comment that describes what the test is doing.
5 years, 10 months ago (2015-02-26 21:15:47 UTC) #4
danakj
https://codereview.chromium.org/959003002/diff/1/cc/layers/picture_layer_unittest.cc File cc/layers/picture_layer_unittest.cc (right): https://codereview.chromium.org/959003002/diff/1/cc/layers/picture_layer_unittest.cc#newcode115 cc/layers/picture_layer_unittest.cc:115: TEST(PictureLayerTest, NonMonotonicSourceFrameNumber) { On 2015/02/26 21:10:23, danakj wrote: > ...
5 years, 10 months ago (2015-02-26 21:17:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959003002/20001
5 years, 10 months ago (2015-02-26 21:18:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 22:09:49 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 22:11:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5537a42c2b6bf70a9c1fa6fed5092747235f1aa4
Cr-Commit-Position: refs/heads/master@{#318326}

Powered by Google App Engine
This is Rietveld 408576698