Verify replacement and activation behavior for notifications on Android.

Verify replacement and activation behavior for notifications on Android.

This CL adds two more Android instrumentation tests for Web Notifications,
which verify that the "tag" property on a notification will replace any
previous notification being shown, and a test verifying that activating
the notification will invoke the Service Worker, closing the notification.

BUG=462251
Committed: https://crrev.com/afbc26a791ad18966e1a630a0012203191df8a57
Cr-Commit-Position: refs/heads/master@{#318704}

[Peter Beverloo, 2015-02-26 19:18:35]

peter@chromium.org changed reviewers:
+ miguelg@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-02-26 19:18:35]

+miguelg and mvanouwerkerk for review

This CL also depends on the main one:
  https://codereview.chromium.org/960923004/

[Michael van Ouwerkerk, 2015-02-27 10:58:12]

These are all nits really. lgtm

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:161:
@LargeTest
Which part makes this test large while the others are medium?

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:171:
notification.contentIntent.send();
Maybe add a comment reminding people that sending the content intent equals
clicking the notification.

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:188:
setNotificationContentSettingForCurrentOrigin(ContentSetting.ALLOW);
Could you extract these first 4 lines of code into a helper? E.g.:
Notification notification = grantPermissionAndShowNotification("title",
"config")

The helper could probably also assert that |notification| is not null.

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:200:
assertEquals(1, notifications.size());
Just to be clear, add the line below, otherwise it could mean the second
notification was dropped instead of it replacing the first one:
assertEquals("SecondNotification",
notifications.valueAt(0).extras.getString(Notification.EXTRA_TITLE));

[Peter Beverloo, 2015-02-27 14:34:06]

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:161:
@LargeTest
On 2015/02/27 10:58:12, Michael van Ouwerkerk wrote:
> Which part makes this test large while the others are medium?

The other tests are Java -> Renderer -> Java. This one is Java -> Renderer ->
Java -> Renderer -> Java.

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:171:
notification.contentIntent.send();
On 2015/02/27 10:58:12, Michael van Ouwerkerk wrote:
> Maybe add a comment reminding people that sending the content intent equals
> clicking the notification.

Done.

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:188:
setNotificationContentSettingForCurrentOrigin(ContentSetting.ALLOW);
On 2015/02/27 10:58:12, Michael van Ouwerkerk wrote:
> Could you extract these first 4 lines of code into a helper? E.g.:
> Notification notification = grantPermissionAndShowNotification("title",
> "config")
> 
> The helper could probably also assert that |notification| is not null.

As discussed offline, I chose merge the assertEquals() in the
setNoficiationContentSettingForCurrentOrigin method and remove the assertNotNull
on notification since we're already doing that elsewhere.

https://codereview.chromium.org/958993002/diff/1/chrome/android/javatests/src...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:200:
assertEquals(1, notifications.size());
On 2015/02/27 10:58:12, Michael van Ouwerkerk wrote:
> Just to be clear, add the line below, otherwise it could mean the second
> notification was dropped instead of it replacing the first one:
> assertEquals("SecondNotification",
> notifications.valueAt(0).extras.getString(Notification.EXTRA_TITLE));

Done.

[Peter Beverloo, 2015-03-02 14:55:42]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-02 14:55:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/958993002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-03-02 14:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958993002/40001

[commit-bot: I haz the power, 2015-03-02 16:01:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-02 16:02:13]

Patchset 3 (id:??) landed as
https://crrev.com/afbc26a791ad18966e1a630a0012203191df8a57
Cr-Commit-Position: refs/heads/master@{#318704}