Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 958973002: Call WebFrameWidget::setVisibilityState on RFI::WasShown (Closed)

Created:
5 years, 9 months ago by kenrb
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call WebFrameWidget::setVisibilityState on RFI::WasShown The call to WebViewImpl::setVisibilityState updates Blink's Page state correctly, but was not notifying the WebFrameWidget's LayerTreeHost. This patch calls a newly added method in WebFrameWidget that resolves some rendering issues. BUG=450674 Committed: https://crrev.com/cafd1ace2d7b52f1fcb4efd04d64af51768ec5c9 Cr-Commit-Position: refs/heads/master@{#318709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kenrb
Nasko: PTAL? I think this is trivial, and is the Chromium side for https://codereview.chromium.org/955143002/, which ...
5 years, 9 months ago (2015-02-27 16:10:06 UTC) #2
nasko
LGTM
5 years, 9 months ago (2015-02-27 16:39:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958973002/1
5 years, 9 months ago (2015-03-02 15:14:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 16:27:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 16:28:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cafd1ace2d7b52f1fcb4efd04d64af51768ec5c9
Cr-Commit-Position: refs/heads/master@{#318709}

Powered by Google App Engine
This is Rietveld 408576698