Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 958933004: ServiceWorker: plumbing for ClientQueryOptions (1/2, blink) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebServiceWorkerClientsInfo.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index 70e71d11a4690efccb9fe6975ea3cea6cb24d724..6ec85acd7368828c9299cec539fa82b8275b4f34 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -42,6 +42,7 @@
namespace blink {
struct WebCrossOriginServiceWorkerClient;
+struct WebServiceWorkerClientQueryOptions;
class WebDataSource;
class WebServiceWorkerCacheStorage;
class WebServiceWorkerContextProxy;
@@ -153,11 +154,17 @@ public:
// This is called on the main thread.
virtual WebServiceWorkerProvider* createServiceWorkerProvider() { return nullptr; }
+ // FIXME: Deprecate this version once the other getClients is implemented
+ // in the embedder.
+ virtual void getClients(WebServiceWorkerClientsCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.
// WebServiceWorkerClientsInfo and WebServiceWorkerError ownerships are
// passed to the WebServiceWorkerClientsCallbacks implementation.
- virtual void getClients(WebServiceWorkerClientsCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ // FIXME: Remove the default implementation once this is implemented
+ // in the embedder.
+ virtual void getClients(const WebServiceWorkerClientQueryOptions&, WebServiceWorkerClientsCallbacks* callbacks) { getClients(callbacks); }
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.
« no previous file with comments | « public/platform/WebServiceWorkerClientsInfo.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698