Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 958923008: Expose out-of-process v8 pac in about:flags. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8-pac-oop
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose out-of-process v8 pac in about:flags. BUG=11746 Committed: https://crrev.com/3f8e83b6f69aacb57e18dcdcaed93397268e4cc6 Cr-Commit-Position: refs/heads/master@{#320464}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
mpearson@chromium.org: Please review changes in histograms thestig@chromium.org: Please review changes in chrome/ I can't submit ...
5 years, 9 months ago (2015-03-10 04:34:27 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-10 04:38:32 UTC) #3
Mark P
histograms.xml lgtm
5 years, 9 months ago (2015-03-10 16:53:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958923008/20001
5 years, 9 months ago (2015-03-13 04:13:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-13 07:31:58 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 07:32:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f8e83b6f69aacb57e18dcdcaed93397268e4cc6
Cr-Commit-Position: refs/heads/master@{#320464}

Powered by Google App Engine
This is Rietveld 408576698