Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 958923003: ChromeOS Gaia: Do not send 'focusready' message when Gaia window is focused (Closed)

Created:
5 years, 9 months ago by Roman Sorokin (ftl)
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Gaia: Do not send 'focusready' message when Gaia window is focused BUG=386557 Committed: https://crrev.com/81a235afe26e84419592a922b81102f5eb4751a4 Cr-Commit-Position: refs/heads/master@{#318245}

Patch Set 1 #

Patch Set 2 : Changed comment #

Total comments: 2

Patch Set 3 : Remove debug output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 2 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Roman Sorokin (ftl)
Hi Nikita, please review
5 years, 9 months ago (2015-02-26 14:58:18 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/958923003/diff/20001/chrome/browser/resources/gaia_auth_host/authenticator.js File chrome/browser/resources/gaia_auth_host/authenticator.js (right): https://codereview.chromium.org/958923003/diff/20001/chrome/browser/resources/gaia_auth_host/authenticator.js#newcode171 chrome/browser/resources/gaia_auth_host/authenticator.js:171: console.error('send message'); What is this error about? Please ...
5 years, 9 months ago (2015-02-26 15:10:51 UTC) #3
Roman Sorokin (ftl)
https://codereview.chromium.org/958923003/diff/20001/chrome/browser/resources/gaia_auth_host/authenticator.js File chrome/browser/resources/gaia_auth_host/authenticator.js (right): https://codereview.chromium.org/958923003/diff/20001/chrome/browser/resources/gaia_auth_host/authenticator.js#newcode171 chrome/browser/resources/gaia_auth_host/authenticator.js:171: console.error('send message'); On 2015/02/26 15:10:50, Nikita wrote: > What ...
5 years, 9 months ago (2015-02-26 15:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958923003/40001
5 years, 9 months ago (2015-02-26 15:16:16 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-02-26 16:21:49 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 16:22:35 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/81a235afe26e84419592a922b81102f5eb4751a4
Cr-Commit-Position: refs/heads/master@{#318245}

Powered by Google App Engine
This is Rietveld 408576698