Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 958923002: MIPS: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. Port e9cdcb71743200e7dd18b0be62f764aa53729c63 Original commit message: Proxies up the chain are guaranteed to provide access if we had access to the receiver, since otherwise we wouldn't have been able to compile the stub in the first place. If the security check would change, the window navigates, changing the map of the JSGlobalProxy. BUG= Committed: https://crrev.com/d471ceff41958d2e80ef5b44fe3a5514ddf36492 Cr-Commit-Position: refs/heads/master@{#26894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 3 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-26 13:28:29 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-26 14:44:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958923002/1
5 years, 10 months ago (2015-02-26 16:56:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 18:39:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:39:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d471ceff41958d2e80ef5b44fe3a5514ddf36492
Cr-Commit-Position: refs/heads/master@{#26894}

Powered by Google App Engine
This is Rietveld 408576698