Issue 958903002: Move activeCues ownership to TextTrack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 958903002: Move activeCues ownership to TextTrack (Closed)

Created:
5 years, 10 months ago by fs

Modified:
5 years, 10 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Move activeCues ownership to TextTrack Instead of having a list that owns another list (that owns another list...), move the m_activeCues member from TextTrackCueList to TextTrack. This is structurally less strange, and makes TextTrackCueList slightly more self-contained. The code for building the activeCues list remains (for now.) BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190923

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	Source/core/html/track/TextTrack.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/track/TextTrack.cpp	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	Source/core/html/track/TextTrackCueList.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/html/track/TextTrackCueList.cpp	View	2 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958903002/1

5 years, 10 months ago (2015-02-26 14:41:52 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 15:41:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190923

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages