Source/core/inspector/CodeGeneratorInspector.py - Issue 958893002: Inspector: Store array of small numbers in 16 bit instead of 64 bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/CodeGeneratorInspector.py

Issue 958893002: Inspector: Store array of small numbers in 16 bit instead of 64 bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/CodeGeneratorInspector.py

diff --git a/Source/core/inspector/CodeGeneratorInspector.py b/Source/core/inspector/CodeGeneratorInspector.py

index 70c7e6c394951bc19ef841439625532986755fd4..59595d6a97f990777a151528243f904831d4b7db 100755

--- a/Source/core/inspector/CodeGeneratorInspector.py

+++ b/Source/core/inspector/CodeGeneratorInspector.py

@@ -1882,6 +1882,7 @@ class Generator:

commandNameIndex=cmd_enum_name))

declaration_command_name = "%s.%s\\0" % (domain_name, json_command_name)

Generator.backend_method_name_declaration_list.append(" \"%s\"" % declaration_command_name)

+ assert Generator.backend_method_name_declaration_current_index < 2 ** 16, "Number too large for unsigned short."

Generator.backend_method_name_declaration_index_list.append(" %d," % Generator.backend_method_name_declaration_current_index)

Generator.backend_method_name_declaration_current_index += len(declaration_command_name) - 1

« no previous file with comments | « no previous file | Source/core/inspector/CodeGeneratorInspectorStrings.py » ('j') | no next file with comments »