Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: cc/layers/picture_layer_impl.h

Issue 958843004: Fix for 424682: Draw correct repaint regions instead of a conservative bounding box (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_PICTURE_LAYER_IMPL_H_ 5 #ifndef CC_LAYERS_PICTURE_LAYER_IMPL_H_
6 #define CC_LAYERS_PICTURE_LAYER_IMPL_H_ 6 #define CC_LAYERS_PICTURE_LAYER_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 // Functions used by tile manager. 99 // Functions used by tile manager.
100 PictureLayerImpl* GetPendingOrActiveTwinLayer() const; 100 PictureLayerImpl* GetPendingOrActiveTwinLayer() const;
101 bool IsOnActiveOrPendingTree() const; 101 bool IsOnActiveOrPendingTree() const;
102 // Virtual for testing. 102 // Virtual for testing.
103 virtual bool HasValidTilePriorities() const; 103 virtual bool HasValidTilePriorities() const;
104 104
105 // Used for benchmarking 105 // Used for benchmarking
106 RasterSource* GetRasterSource() const { return raster_source_.get(); } 106 RasterSource* GetRasterSource() const { return raster_source_.get(); }
107 107
108 Region GetInvalidationRegion() override;
danakj 2015/02/26 23:53:05 move this up with the LayerImpl overrides
daplatz 2015/02/27 11:04:56 Acknowledged.
109
108 protected: 110 protected:
109 friend class LayerRasterTileIterator; 111 friend class LayerRasterTileIterator;
110 using TileRequirementCheck = bool (PictureLayerTiling::*)(const Tile*) const; 112 using TileRequirementCheck = bool (PictureLayerTiling::*)(const Tile*) const;
111 113
112 PictureLayerImpl(LayerTreeImpl* tree_impl, 114 PictureLayerImpl(LayerTreeImpl* tree_impl,
113 int id, 115 int id,
114 bool is_mask, 116 bool is_mask,
115 scoped_refptr<SyncedScrollOffset> scroll_offset); 117 scoped_refptr<SyncedScrollOffset> scroll_offset);
116 PictureLayerTiling* AddTiling(float contents_scale); 118 PictureLayerTiling* AddTiling(float contents_scale);
117 void RemoveAllTilings(); 119 void RemoveAllTilings();
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // of comparing pointers, since objects pointed to are not guaranteed to 178 // of comparing pointers, since objects pointed to are not guaranteed to
177 // exist. 179 // exist.
178 std::vector<PictureLayerTiling*> last_append_quads_tilings_; 180 std::vector<PictureLayerTiling*> last_append_quads_tilings_;
179 181
180 DISALLOW_COPY_AND_ASSIGN(PictureLayerImpl); 182 DISALLOW_COPY_AND_ASSIGN(PictureLayerImpl);
181 }; 183 };
182 184
183 } // namespace cc 185 } // namespace cc
184 186
185 #endif // CC_LAYERS_PICTURE_LAYER_IMPL_H_ 187 #endif // CC_LAYERS_PICTURE_LAYER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698