Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 958843003: ChromeOS Gaia: When webview is enabled CrOS get oauth_code from accounts.sandbox.google.com and mak… (Closed)

Created:
5 years, 9 months ago by Roman Sorokin (ftl)
Modified:
5 years, 9 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Gaia: When webview is enabled CrOS get oauth_code from accounts.sandbox.google.com and make all the other auths against the default gaia url. BUG=461854 Committed: https://crrev.com/2c19ad9ecb250f1be2c3a3f3adac978bb8d4f0cc Cr-Commit-Position: refs/heads/master@{#318228}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Roman Sorokin (ftl)
Hi Dmitry, please review
5 years, 9 months ago (2015-02-26 12:37:43 UTC) #2
Dmitry Polukhin
lgtm https://codereview.chromium.org/958843003/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/958843003/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode58 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:58: // TODO(rsorokin): Get rid of this url before ...
5 years, 9 months ago (2015-02-26 12:54:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958843003/20001
5 years, 9 months ago (2015-02-26 13:25:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 14:02:15 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 14:03:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c19ad9ecb250f1be2c3a3f3adac978bb8d4f0cc
Cr-Commit-Position: refs/heads/master@{#318228}

Powered by Google App Engine
This is Rietveld 408576698