Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 958843002: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. Proxies up the chai… (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
dcarney, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. Proxies up the chain are guaranteed to provide access if we had access to the receiver, since otherwise we wouldn't have been able to compile the stub in the first place. If the security check would change, the window navigates, changing the map of the JSGlobalProxy. BUG= Committed: https://crrev.com/e9cdcb71743200e7dd18b0be62f764aa53729c63 Cr-Commit-Position: refs/heads/master@{#26875}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -67 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 3 chunks +12 lines, -18 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 3 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-26 10:13:20 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-26 10:19:52 UTC) #3
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-26 10:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958843002/20001
5 years, 10 months ago (2015-02-26 10:44:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 11:06:32 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 11:06:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9cdcb71743200e7dd18b0be62f764aa53729c63
Cr-Commit-Position: refs/heads/master@{#26875}

Powered by Google App Engine
This is Rietveld 408576698