chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 958803004: [Extensions] Make chrome://extensions use developerPrivate for packing crxs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 958803004: [Extensions] Make chrome://extensions use developerPrivate for packing crxs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/pack_extension_overlay.js ('K') | « chrome/browser/resources/extensions/pack_extension_overlay.js ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | chrome/common/extensions/api/developer_private.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index b7ea12fcb854705a2afab322e09a821ba0f9878c..c21555f79563f938d677a3d36b9c1946196fd9d5 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -636,6 +636,30 @@ void ExtensionSettingsHandler::GetLocalizedValues(

// uber extensions.

source->AddString("extensionUninstall",

l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));

+ // Pack Extension Overlay:

+ source->AddString("packExtensionOverlay",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_TITLE));

+ source->AddString("packExtensionHeading",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_HEADING));

+ source->AddString("packExtensionCommit",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_BUTTON));

+ source->AddString("ok", l10n_util::GetStringUTF16(IDS_OK));

+ source->AddString("cancel", l10n_util::GetStringUTF16(IDS_CANCEL));

+ source->AddString("packExtensionRootDir",

+ l10n_util::GetStringUTF16(

+ IDS_EXTENSION_PACK_DIALOG_ROOT_DIRECTORY_LABEL));

+ source->AddString("packExtensionPrivateKey",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_PRIVATE_KEY_LABEL));

+ source->AddString("packExtensionBrowseButton",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_BROWSE));

+ source->AddString("packExtensionProceedAnyway",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PROCEED_ANYWAY));

+ source->AddString("packExtensionWarningTitle",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_WARNING_TITLE));

+ source->AddString("packExtensionErrorTitle",

+ l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_ERROR_TITLE));

}

void ExtensionSettingsHandler::RenderViewDeleted(