Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/mojo/mojom_bindings_generator.gypi

Issue 958773002: Fix stale mojom-generated Java problems with gyp builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: actually set additional_input_paths correctly -_- Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/rmdir_and_stamp.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mojo/mojom_bindings_generator.gypi
diff --git a/third_party/mojo/mojom_bindings_generator.gypi b/third_party/mojo/mojom_bindings_generator.gypi
index e58aab34401e2c543761f89f17d26e914c132e6f..e18ab05e63839e3b83a08ab70d950188c8d68563 100644
--- a/third_party/mojo/mojom_bindings_generator.gypi
+++ b/third_party/mojo/mojom_bindings_generator.gypi
@@ -6,6 +6,24 @@
'includes': [
'mojom_bindings_generator_variables.gypi',
],
+ 'actions': [
+ {
+ 'variables': {
+ 'java_out_dir': '<(PRODUCT_DIR)/java_mojo/<(_target_name)/src',
+ 'stamp_filename': '<(PRODUCT_DIR)/java_mojo/<(_target_name)/<(_target_name).stamp',
+ },
+ 'action_name': '<(_target_name)_mojom_bindings_stamp',
+ # The java output directory is deleted to ensure that the java library
+ # doesn't try to compile stale files.
+ 'action': [
+ 'python', '<(DEPTH)/build/rmdir_and_stamp.py',
+ '<(java_out_dir)',
+ '<(stamp_filename)',
+ ],
+ 'inputs': [ '<@(_sources)' ],
+ 'outputs': [ '<(stamp_filename)' ],
+ }
+ ],
'rules': [
{
'rule_name': '<(_target_name)_mojom_bindings_generator',
@@ -18,9 +36,11 @@
'-I<(DEPTH)',
'-I<(DEPTH)/third_party/mojo/src'
],
+ 'stamp_filename': '<(PRODUCT_DIR)/java_mojo/<(_target_name)/<(_target_name).stamp',
},
'inputs': [
'<@(mojom_bindings_generator_sources)',
+ '<(stamp_filename)',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/<(mojom_base_output_dir)/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).mojom.cc',
@@ -59,6 +79,10 @@
'generated_src_dirs': [
'<(PRODUCT_DIR)/java_mojo/<(_target_name)/src',
],
+ 'additional_input_paths': [
+ '<@(mojom_bindings_generator_sources)',
+ '<@(_sources)',
+ ],
},
},
'hard_dependency': 1,
« no previous file with comments | « build/rmdir_and_stamp.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698