Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: BUILD.gn

Issue 958743003: Add chrome driver to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_audit
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index cc4e52ac0781835d6188448b810228b8dd04a6eb..700ff9c1f77c5ce8ed7f300d42181dc46e1d2449 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -32,7 +32,6 @@ group("gyp_all") {
deps = [
":gn_all",
- # "//chrome/test:chromedriver_unittests", # TODO(GYP)
# "//components:components_browsertests", # TODO(GYP)
# "//components/nacl:nacl_loader_unittests", # TODO(GYP)
# "//google_apis:google_apis_unittests", # TODO(GYP)
@@ -61,6 +60,7 @@ group("gn_all") {
"//chrome/test:interactive_ui_tests",
"//chrome/test:sync_integration_tests",
"//chrome/test:unit_tests",
+ "//chrome/test/chromedriver:chromedriver_unittests",
"//components:components_unittests",
"//content/shell:content_shell",
"//content/test:content_browsertests",
@@ -306,7 +306,6 @@ if (is_linux) {
group("linux_default_tests") {
testonly = true
deps = [
- # chromedriver_unittests TODO(GYP)
# components_browsertests TODO(GYP)
# device_unittests TODO(GYP)
# nacl_loader_unittests TODO(GYP)
@@ -317,8 +316,9 @@ if (is_linux) {
"//cc:cc_unittests", # PASSES 2/25/2015
"//chrome/test:browser_tests",
"//chrome/test:interactive_ui_tests",
- "//chrome/test:sync_integration_tests", # TODO(GYP) multiple crashes.
+ "//chrome/test:sync_integration_tests", # Crashes for brettw in GN and GYP.
"//chrome/test:unit_tests", # PASSES 2/25/2015
+ "//chrome/test/chromedriver:chromedriver_unittests", # PASSES 2/25/2015
"//components:components_unittests", # TODO(GYP) multiple crashes.
"//content/test:content_browsertests",
"//content/test:content_unittests", # PASSES 2/25/2015
« no previous file with comments | « no previous file | chrome/chrome_tests.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698