Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 958743003: Add chrome driver to the GN build. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_audit
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome driver to the GN build. BUG= Committed: https://crrev.com/ad912fc2a22d3ddd4c52cb70b487fcb268941ec2 Cr-Commit-Position: refs/heads/master@{#318272}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -83 lines) Patch
M BUILD.gn View 4 chunks +3 lines, -3 lines 0 comments Download
A chrome/chrome_tests.gni View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 11 chunks +17 lines, -8 lines 0 comments Download
M chrome/test/BUILD.gn View 1 16 chunks +86 lines, -72 lines 0 comments Download
A chrome/test/chromedriver/BUILD.gn View 1 chunk +224 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
brettw
Depends on https://codereview.chromium.org/961473002/
5 years, 9 months ago (2015-02-25 23:33:46 UTC) #2
Dirk Pranke
+tfarina, since you're folding in his CL lgtm, but I'm not seeing the dependency on ...
5 years, 9 months ago (2015-02-25 23:37:39 UTC) #3
tfarina
On 2015/02/25 23:37:39, Dirk Pranke wrote: > +tfarina, since you're folding in his CL > ...
5 years, 9 months ago (2015-02-25 23:42:06 UTC) #4
brettw
Dirk: the dependency is on the changes in BUILD.gn (the new linux tests project). Thiago: ...
5 years, 9 months ago (2015-02-26 17:41:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958743003/20001
5 years, 9 months ago (2015-02-26 17:58:39 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
5 years, 9 months ago (2015-02-26 18:49:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958743003/20001
5 years, 9 months ago (2015-02-26 18:52:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 18:53:41 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ad912fc2a22d3ddd4c52cb70b487fcb268941ec2 Cr-Commit-Position: refs/heads/master@{#318272}
5 years, 9 months ago (2015-02-26 18:54:37 UTC) #15
mlamouri (slow - plz ping)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/963063002/ by mlamouri@chromium.org. ...
5 years, 9 months ago (2015-02-27 12:27:39 UTC) #16
brettw
5 years, 9 months ago (2015-02-27 20:33:02 UTC) #17
Message was sent while issue was closed.
You didn't provide any links to failures and the Android GN bot shows all green
over the last 200 builds. Without more information, there's nothing I can do but
reland as-is. Will keep an eye out for failures.

Powered by Google App Engine
This is Rietveld 408576698