isolate cast_unittests

isolate cast_unittests

R=maruel@chromium.org
TBR=jam@chromium.org
BUG=98637
Committed: https://chromium.googlesource.com/chromium/src/+/072866f18863c8596d84b430030bf26db147f13f

[chromium-reviews, 2015-02-25 22:40:39]

Hi here,

What does it mean by isolating a test?

Alpha

2015-02-25 14:39 GMT-08:00 <scottmg@chromium.org>:

> Reviewers: M-A Ruel,
>
> Description:
> isolate cast_unittests
>
> R=maruel@chromium.org
> BUG=98637
>
> Please review this at https://codereview.chromium.org/958733002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+169, -87 lines):
>   M media/cast/cast_testing.gypi
>   A + media/cast/cast_unittests.isolate
>   M testing/buildbot/chromium.linux.json
>   M testing/buildbot/chromium.mac.json
>   M testing/buildbot/chromium.win.json
>   M testing/buildbot/chromium_trybot.json
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2015-02-25 22:42:01]

On 2015/02/25 22:40:39, chromium-reviews wrote:
> Hi here,
> 
> What does it mean by isolating a test?
> 
> Alpha
> 
> 2015-02-25 14:39 GMT-08:00 <mailto:scottmg@chromium.org>:
> 
> > Reviewers: M-A Ruel,
> >
> > Description:
> > isolate cast_unittests
> >
> > mailto:R=maruel@chromium.org
> > BUG=98637
> >
> > Please review this at https://codereview.chromium.org/958733002/
> >
> > Base URL: https://chromium.googlesource.com/chromium/src.git@master
> >
> > Affected files (+169, -87 lines):
> >   M media/cast/cast_testing.gypi
> >   A + media/cast/cast_unittests.isolate
> >   M testing/buildbot/chromium.linux.json
> >   M testing/buildbot/chromium.mac.json
> >   M testing/buildbot/chromium.win.json
> >   M testing/buildbot/chromium_trybot.json
> >
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

See http://www.chromium.org/developers/testing/isolated-testing/for-swes. It
runs the test across multiple slave machines, rather than on a single machine.

[chromium-reviews, 2015-02-25 22:42:44]

Cool. I see.


2015-02-25 14:42 GMT-08:00 <scottmg@chromium.org>:

> On 2015/02/25 22:40:39, chromium-reviews wrote:
>
>> Hi here,
>>
>
>  What does it mean by isolating a test?
>>
>
>  Alpha
>>
>
>  2015-02-25 14:39 GMT-08:00 <mailto:scottmg@chromium.org>:
>>
>
>  > Reviewers: M-A Ruel,
>> >
>> > Description:
>> > isolate cast_unittests
>> >
>> > mailto:R=maruel@chromium.org
>> > BUG=98637
>> >
>> > Please review this at https://codereview.chromium.org/958733002/
>> >
>> > Base URL: https://chromium.googlesource.com/chromium/src.git@master
>> >
>> > Affected files (+169, -87 lines):
>> >   M media/cast/cast_testing.gypi
>> >   A + media/cast/cast_unittests.isolate
>> >   M testing/buildbot/chromium.linux.json
>> >   M testing/buildbot/chromium.mac.json
>> >   M testing/buildbot/chromium.win.json
>> >   M testing/buildbot/chromium_trybot.json
>> >
>> >
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> See http://www.chromium.org/developers/testing/isolated-testing/for-swes.
> It
> runs the test across multiple slave machines, rather than on a single
> machine.
>
> https://codereview.chromium.org/958733002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-02-25 22:44:25]

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_testing.gypi
File media/cast/cast_testing.gypi (right):

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_testing.gypi...
media/cast/cast_testing.gypi:376: ],
alignment?

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_unittests.is...
File media/cast/cast_unittests.isolate (right):

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_unittests.is...
media/cast/cast_unittests.isolate:11:
'<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
copy pasted

[scottmg, 2015-02-25 22:48:52]

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_testing.gypi
File media/cast/cast_testing.gypi (right):

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_testing.gypi...
media/cast/cast_testing.gypi:376: ],
On 2015/02/25 22:44:25, M-A Ruel wrote:
> alignment?

Done.

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_unittests.is...
File media/cast/cast_unittests.isolate (right):

https://codereview.chromium.org/958733002/diff/1/media/cast/cast_unittests.is...
media/cast/cast_unittests.isolate:11:
'<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
On 2015/02/25 22:44:25, M-A Ruel wrote:
> copy pasted

Done.

[scottmg, 2015-02-25 23:42:13]

Patchset #3 (id:40001) has been deleted

[M-A Ruel, 2015-02-26 01:07:01]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2015-02-26 01:07:02]

lgtm

https://codereview.chromium.org/958733002/diff/60001/media/cast/cast_unittest...
File media/cast/cast_unittests.isolate (right):

https://codereview.chromium.org/958733002/diff/60001/media/cast/cast_unittest...
media/cast/cast_unittests.isolate:38: 'read_only': 1,
read_only:1 is now the default so it's not needed anymore.

[commit-bot: I haz the power, 2015-02-26 01:07:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958733002/60001

[scottmg, 2015-02-26 01:09:27]

https://codereview.chromium.org/958733002/diff/60001/media/cast/cast_unittest...
File media/cast/cast_unittests.isolate (right):

https://codereview.chromium.org/958733002/diff/60001/media/cast/cast_unittest...
media/cast/cast_unittests.isolate:38: 'read_only': 1,
On 2015/02/26 01:07:02, M-A Ruel wrote:
> read_only:1 is now the default so it's not needed anymore.

Done.

[scottmg, 2015-02-26 01:09:35]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-02-26 01:09:36]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/958733002/#ps80001 (title:
"no read_only")

[commit-bot: I haz the power, 2015-02-26 01:10:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958733002/80001

[scottmg, 2015-02-26 01:10:56]

scottmg@chromium.org changed reviewers:
+ jam@chromium.org

[commit-bot: I haz the power, 2015-02-26 01:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 01:12:59]

Try jobs failed on following builders:
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2015-02-26 01:19:09]

Patchset 4 (id:??) landed as
https://crrev.com/072866f18863c8596d84b430030bf26db147f13f
Cr-Commit-Position: refs/heads/master@{#318167}

[scottmg, 2015-02-26 01:19:24]

Committed patchset #4 (id:80001) manually as
072866f18863c8596d84b430030bf26db147f13f (presubmit successful).

[earthdok, 2015-02-26 17:57:08]

On 2015/02/26 01:19:24, scottmg wrote:
> Committed patchset #4 (id:80001) manually as
> 072866f18863c8596d84b430030bf26db147f13f (presubmit successful).

Gah! This file has Windows-style line endings. This is causing confusing patch
failures:

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

I'll submit a CL to clean it up. Also:
https://code.google.com/p/chromium/issues/detail?id=420796#c9

[scottmg, 2015-02-26 18:00:47]

Sorry! I have set ff=unix for most file types, but never added .isolate.
Thanks for fixing.

On Thu, Feb 26, 2015 at 9:57 AM, <earthdok@chromium.org> wrote:

> On 2015/02/26 01:19:24, scottmg wrote:
>
>> Committed patchset #4 (id:80001) manually as
>> 072866f18863c8596d84b430030bf26db147f13f (presubmit successful).
>>
>
> Gah! This file has Windows-style line endings. This is causing confusing
> patch
> failures:
>
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/linux_chromium_chromeos_asan_rel_ng/builds/
> 1145/steps/bot_update/logs/patch%20error
>
> I'll submit a CL to clean it up. Also:
> https://code.google.com/p/chromium/issues/detail?id=420796#c9
>
>
> https://codereview.chromium.org/958733002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.