Remove dependency on XMPP implementation in WebRTC

Remove dependency on XMPP implementation in WebRTC

Now XMPP is implemented directly in remoting/signaling instead of
relying on WebRTC. The new code is mostly just a translation of
the XMPP implementation we use in the webapp from JavaScript to
C++ and uses the same layout and class names, except that the main
class is called XmppSignalStrategy instead of XmppConnection.

BUG=459756, 443806, 417336
Committed: https://crrev.com/76d9000d15c864bb96db8adea06441689517aa00
Cr-Commit-Position: refs/heads/master@{#319712}

[Sergey Ulanov, 2015-02-25 22:27:40]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2015-02-25 22:29:15]

sergeyu@chromium.org changed reviewers:
+ rmsousa@chromium.org

[Sergey Ulanov, 2015-02-28 05:29:34]

ping

[rmsousa, 2015-02-28 06:33:29]

lgtm

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
File remoting/signaling/xmpp_login_handler.cc (right):

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_login_handler.cc:45: auth_mechanism_((auth_service ==
"oauth2") ? "X-OAUTH2"
nit: if this is for client login, it can be removed now.

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
File remoting/signaling/xmpp_signal_strategy.cc (right):

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_signal_strategy.cc:141:
DCHECK(xmpp_server_config_.use_tls);
could you add a // TODO to support it no tls in debug builds? We need to disable
tls to talk to test/local servers (without that we have no way to test server
features end-to-end)

Also, even though right now it has no effect, it's probably a good idea to keep
CHECKing that tls is enabled on release build.

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_signal_strategy.cc:265: // Reset the writer so we don't
try to write to the row socket anymore.
nit: raw socket

[weitao, 2015-02-28 07:23:49]

weitaosu@chromium.org changed reviewers:
+ weitaosu@chromium.org

[weitao, 2015-02-28 07:23:49]

Drive-by nit.

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
File remoting/signaling/xmpp_login_handler.h (right):

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_login_handler.h:17: // XmppLoginHandler handles
authentication handshake for XmppConnection. It
s/XmppConnection/XmppSignalStrategy ?

[Sergey Ulanov, 2015-03-02 18:11:10]

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
File remoting/signaling/xmpp_login_handler.cc (right):

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_login_handler.cc:45: auth_mechanism_((auth_service ==
"oauth2") ? "X-OAUTH2"
On 2015/02/28 06:33:29, rmsousa wrote:
> nit: if this is for client login, it can be removed now.

Done.

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
File remoting/signaling/xmpp_login_handler.h (right):

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_login_handler.h:17: // XmppLoginHandler handles
authentication handshake for XmppConnection. It
On 2015/02/28 07:23:49, weitaosu wrote:
> s/XmppConnection/XmppSignalStrategy ?

Done.

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
File remoting/signaling/xmpp_signal_strategy.cc (right):

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_signal_strategy.cc:141:
DCHECK(xmpp_server_config_.use_tls);
On 2015/02/28 06:33:29, rmsousa wrote:
> could you add a // TODO to support it no tls in debug builds? We need to
disable
> tls to talk to test/local servers (without that we have no way to test server
> features end-to-end)
> 
> Also, even though right now it has no effect, it's probably a good idea to
keep
> CHECKing that tls is enabled on release build.

Implemented support for non-tls connections now.

https://codereview.chromium.org/958703003/diff/20001/remoting/signaling/xmpp_...
remoting/signaling/xmpp_signal_strategy.cc:265: // Reset the writer so we don't
try to write to the row socket anymore.
On 2015/02/28 06:33:29, rmsousa wrote:
> nit: raw socket

Done.

[Sergey Ulanov, 2015-03-02 18:12:10]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-02 18:12:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-03-02 18:14:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/60001

[commit-bot: I haz the power, 2015-03-02 18:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 18:43:26]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-03-02 21:37:14]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-02 21:37:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-03-02 21:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/80001

[commit-bot: I haz the power, 2015-03-02 22:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 22:50:07]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-03-03 18:48:42]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-03 18:48:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-03-03 18:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/100001

[commit-bot: I haz the power, 2015-03-03 21:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-03 21:39:16]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Sergey Ulanov, 2015-03-03 23:51:06]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-03 23:51:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-03-03 23:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/120001

[commit-bot: I haz the power, 2015-03-04 02:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 02:23:00]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Sergey Ulanov, 2015-03-04 18:28:46]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-04 18:28:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-03-04 18:29:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/140001

[commit-bot: I haz the power, 2015-03-04 21:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 21:18:44]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Sergey Ulanov, 2015-03-04 21:58:14]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-04 21:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-03-04 21:59:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/160001

[commit-bot: I haz the power, 2015-03-05 02:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 02:58:08]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-03-06 00:52:54]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-06 00:52:54]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-03-06 00:53:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/180001

[commit-bot: I haz the power, 2015-03-06 01:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 01:56:39]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-03-06 05:26:14]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-06 05:26:14]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps200001
(title: " ")

[commit-bot: I haz the power, 2015-03-06 05:26:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/200001

[commit-bot: I haz the power, 2015-03-06 09:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 09:14:02]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-03-09 17:57:10]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-09 17:57:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps220001
(title: " ")

[commit-bot: I haz the power, 2015-03-09 17:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/220001

[commit-bot: I haz the power, 2015-03-09 18:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 18:06:11]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[Sergey Ulanov, 2015-03-09 18:22:21]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-03-09 18:22:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rmsousa@chromium.org
Link to the patchset: https://codereview.chromium.org/958703003/#ps240001
(title: " ")

[commit-bot: I haz the power, 2015-03-09 18:23:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958703003/240001

[commit-bot: I haz the power, 2015-03-09 19:42:20]

Committed patchset #12 (id:240001)

[commit-bot: I haz the power, 2015-03-09 19:43:00]

Patchset 12 (id:??) landed as
https://crrev.com/76d9000d15c864bb96db8adea06441689517aa00
Cr-Commit-Position: refs/heads/master@{#319712}