Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 958693002: Fix bump scrolling doesn't work if the app is in fullscreen mode before connecting. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bump scrolling doesn't work if the app is in fullscreen mode before connecting. With the change, https://codereview.chromium.org/875583002, it is possible to start a remote connection in fullscreen mode, we simply need to notify the DesktopConnectedView that we are in fullscreen upon connecting. BUG=461609 Committed: https://crrev.com/a219cf273369cc6ff1ed2187d56b46f663f54ef0 Cr-Commit-Position: refs/heads/master@{#318130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M remoting/webapp/crd/js/desktop_connected_view.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kelvinp
PTAL
5 years, 10 months ago (2015-02-25 19:30:24 UTC) #2
Jamie
lgtm
5 years, 10 months ago (2015-02-25 21:13:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958693002/1
5 years, 10 months ago (2015-02-25 21:30:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 22:44:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 22:46:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a219cf273369cc6ff1ed2187d56b46f663f54ef0
Cr-Commit-Position: refs/heads/master@{#318130}

Powered by Google App Engine
This is Rietveld 408576698