Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 958673002: Added ServiceRegistry interface (Closed)

Created:
5 years, 10 months ago by hansmuller
Modified:
5 years, 9 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Added ServiceRegistry interface ServiceRegistry enables a chain of Mojo applications to accumulate services without wrapping and forwarding the incoming ServiceProvider request. Sky's DocumentView adds ViewManagerClient to the ServiceRegistry (if any) that's provided to it via ConnectToApplication(). Sky applications can add additional services with embedder.serviceRegistry.addServices(). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dbce5e2e1ce749bb4903b210f787e38ee3139e15

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 5

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -13 lines) Patch
M services/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A + services/service_registry/BUILD.gn View 1 2 3 4 5 6 1 chunk +8 lines, -3 lines 0 comments Download
A services/service_registry/service_registry.mojom View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M sky/framework/embedder.dart View 1 2 3 4 5 6 7 2 chunks +17 lines, -9 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sky/viewer/document_view.h View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 2 3 4 5 6 4 chunks +18 lines, -0 lines 0 comments Download
M sky/viewer/internals.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M sky/viewer/internals.cc View 1 2 3 4 5 6 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hansmuller1
PTAL
5 years, 9 months ago (2015-02-26 23:07:52 UTC) #3
abarth-chromium
https://codereview.chromium.org/958673002/diff/100001/sky/BUILD.gn File sky/BUILD.gn (right): https://codereview.chromium.org/958673002/diff/100001/sky/BUILD.gn#newcode16 sky/BUILD.gn:16: "//sky/services/service_registry", IMHO, this should be in //services. It's not ...
5 years, 9 months ago (2015-02-26 23:28:04 UTC) #4
hansmuller1
https://codereview.chromium.org/958673002/diff/100001/sky/BUILD.gn File sky/BUILD.gn (right): https://codereview.chromium.org/958673002/diff/100001/sky/BUILD.gn#newcode16 sky/BUILD.gn:16: "//sky/services/service_registry", On 2015/02/26 23:28:04, abarth wrote: > IMHO, this ...
5 years, 9 months ago (2015-02-27 03:16:07 UTC) #5
hansmuller1
I've made the suggested changes. PTAL
5 years, 9 months ago (2015-02-27 03:31:47 UTC) #6
abarth-chromium
LGTM Thanks! https://codereview.chromium.org/958673002/diff/140001/services/service_registry/service_registry.mojom File services/service_registry/service_registry.mojom (right): https://codereview.chromium.org/958673002/diff/140001/services/service_registry/service_registry.mojom#newcode5 services/service_registry/service_registry.mojom:5: module sky; module service_registry?
5 years, 9 months ago (2015-02-27 07:48:22 UTC) #7
hansmuller1
https://codereview.chromium.org/958673002/diff/140001/services/service_registry/service_registry.mojom File services/service_registry/service_registry.mojom (right): https://codereview.chromium.org/958673002/diff/140001/services/service_registry/service_registry.mojom#newcode5 services/service_registry/service_registry.mojom:5: module sky; On 2015/02/27 07:48:22, abarth wrote: > module ...
5 years, 9 months ago (2015-02-27 15:39:51 UTC) #8
hansmuller
5 years, 9 months ago (2015-02-27 15:42:07 UTC) #9
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) manually as
dbce5e2e1ce749bb4903b210f787e38ee3139e15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698