Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 958623002: Rebase GDBJIT interface solely on JITCodeEvent (Closed)

Created:
5 years, 10 months ago by wingo
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rebase GDBJIT interface solely on JITCodeEvent R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/652061ed7231cb722cc8246cdc7f6866110d4358 Cr-Commit-Position: refs/heads/master@{#26858}

Patch Set 1 #

Patch Set 2 : Fix compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -259 lines) Patch
M src/compiler.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +20 lines, -9 lines 0 comments Download
M src/gdb-jit.h View 1 chunk +23 lines, -38 lines 0 comments Download
M src/gdb-jit.cc View 1 17 chunks +156 lines, -192 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
wingo
This is a re-land of https://codereview.chromium.org/957673004/, having removed the useless and incorrect "class JITCodeEntry;" redeclaration ...
5 years, 10 months ago (2015-02-25 13:04:40 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
5 years, 10 months ago (2015-02-25 13:16:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958623002/1
5 years, 10 months ago (2015-02-25 13:30:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/161)
5 years, 10 months ago (2015-02-25 13:43:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958623002/20001
5 years, 10 months ago (2015-02-25 15:18:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 15:40:46 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:41:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/652061ed7231cb722cc8246cdc7f6866110d4358
Cr-Commit-Position: refs/heads/master@{#26858}

Powered by Google App Engine
This is Rietveld 408576698