Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 958603002: Added VariableUse expression to tree IR. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated docs regarding catch parameters Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 56f8c3fae10dfe771a7028818b06a80f7fdd1702..368de299aa295a7bd543afc5ec2fa92063e13c93 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -344,8 +344,12 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
}
@override
- js.Expression visitVariable(tree_ir.Variable node) {
- return new js.VariableUse(getVariableName(node));
+ js.Expression visitVariableUse(tree_ir.VariableUse node) {
+ return buildVariableAccess(node.variable);
+ }
+
+ js.Expression buildVariableAccess(tree_ir.Variable variable) {
+ return new js.VariableUse(getVariableName(variable));
}
@override
@@ -403,7 +407,7 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
js.Expression definition = visitExpression(value);
accumulator.add(new js.ExpressionStatement(new js.Assignment(
- visitVariable(node.variable),
+ buildVariableAccess(node.variable),
definition)));
visitStatement(node.next);
}

Powered by Google App Engine
This is Rietveld 408576698