Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 958533002: [turbofan] Don't introduce additional computation when hoisting out of loops. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't introduce additional computation when hoisting out of loops. Committed: https://crrev.com/b1c2a3495624a9776c7df865d972886f2d078c10 Cr-Commit-Position: refs/heads/master@{#26841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M src/compiler/scheduler.cc View 6 chunks +29 lines, -10 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-25 07:20:17 UTC) #2
Jarin
lgtm
5 years, 10 months ago (2015-02-25 07:39:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958533002/1
5 years, 10 months ago (2015-02-25 08:10:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 08:11:45 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 08:12:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c2a3495624a9776c7df865d972886f2d078c10
Cr-Commit-Position: refs/heads/master@{#26841}

Powered by Google App Engine
This is Rietveld 408576698