Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 958433004: fix for msan (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/gpu/GrBatchTarget.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/GrBatchTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
5 years, 10 months ago (2015-02-24 20:40:29 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/958433004/diff/1/src/gpu/GrBatchTarget.h File src/gpu/GrBatchTarget.h (right): https://codereview.chromium.org/958433004/diff/1/src/gpu/GrBatchTarget.h#newcode87 src/gpu/GrBatchTarget.h:87: void putBackIndices(size_t indices) { oneliners?
5 years, 10 months ago (2015-02-24 21:05:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958433004/20001
5 years, 10 months ago (2015-02-24 21:15:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 21:21:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6065b88d1cb17ec2bfefbb34378acf6337f233a1

Powered by Google App Engine
This is Rietveld 408576698