Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 958403004: [Ozone-Gbm] Explicitly crash if trying software rendering on GBM (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Gbm] Explicitly crash if trying software rendering on GBM Software rendering isn't supported on the GBM platform. Rather than allow callers to crash due to nullptr accesses, crash explicitly so we get more meaningfull crash reports. BUG=461396 Committed: https://crrev.com/3e658b23710143f92286bca571d883a1f161c15d Cr-Commit-Position: refs/heads/master@{#318728}

Patch Set 1 #

Total comments: 2

Patch Set 2 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/ozone/platform/dri/gbm_surface_factory.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dnicoara
PTAL
5 years, 9 months ago (2015-02-28 00:38:52 UTC) #2
spang
lgtm https://codereview.chromium.org/958403004/diff/1/ui/ozone/platform/dri/gbm_surface_factory.h File ui/ozone/platform/dri/gbm_surface_factory.h (right): https://codereview.chromium.org/958403004/diff/1/ui/ozone/platform/dri/gbm_surface_factory.h#newcode33 ui/ozone/platform/dri/gbm_surface_factory.h:33: gfx::AcceleratedWidget widget); override;
5 years, 9 months ago (2015-02-28 00:44:45 UTC) #3
dnicoara
https://codereview.chromium.org/958403004/diff/1/ui/ozone/platform/dri/gbm_surface_factory.h File ui/ozone/platform/dri/gbm_surface_factory.h (right): https://codereview.chromium.org/958403004/diff/1/ui/ozone/platform/dri/gbm_surface_factory.h#newcode33 ui/ozone/platform/dri/gbm_surface_factory.h:33: gfx::AcceleratedWidget widget); On 2015/02/28 00:44:45, spang wrote: > override; ...
5 years, 9 months ago (2015-03-02 16:18:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958403004/20001
5 years, 9 months ago (2015-03-02 18:23:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 18:56:06 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 18:56:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e658b23710143f92286bca571d883a1f161c15d
Cr-Commit-Position: refs/heads/master@{#318728}

Powered by Google App Engine
This is Rietveld 408576698