Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 958403003: ozone: evdev: Release pressed keys when event filtering starts (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
pkotwicz, rsadam
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Release pressed keys when event filtering starts This prevents filtering out key release events, resulting in stuck keys. BUG=449162 TEST=Fully rotate glimmer while holding spacebar. No spurious key repeats. Committed: https://crrev.com/df407c56b6491906362df48f228b8a2d972192b8 Cr-Commit-Position: refs/heads/master@{#318535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ui/events/ozone/evdev/input_controller_evdev.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 9 months ago (2015-02-27 20:44:31 UTC) #2
pkotwicz
LGTM
5 years, 9 months ago (2015-02-27 21:43:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958403003/1
5 years, 9 months ago (2015-02-27 22:26:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 22:43:48 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 22:44:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df407c56b6491906362df48f228b8a2d972192b8
Cr-Commit-Position: refs/heads/master@{#318535}

Powered by Google App Engine
This is Rietveld 408576698